tracing/tracing/ui/analysis/memory_dump_overview_pane_test.html - Issue 2955043002: Remove tr.b.asArray.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tracing/tracing/ui/analysis/memory_dump_overview_pane_test.html

Issue 2955043002: Remove tr.b.asArray. (Closed)

Patch Set: Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tracing/tracing/ui/analysis/memory_dump_allocator_details_pane_test.html ('k') | tracing/tracing/ui/analysis/memory_dump_sub_view_test_utils.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tracing/tracing/ui/analysis/memory_dump_overview_pane_test.html

diff --git a/tracing/tracing/ui/analysis/memory_dump_overview_pane_test.html b/tracing/tracing/ui/analysis/memory_dump_overview_pane_test.html

index f2d0a5b4e426f5bbc77b9aec2dfeaac84426b705..8b77854cc240f3d3b843b9d2b52bf2d51badc823 100644

--- a/tracing/tracing/ui/analysis/memory_dump_overview_pane_test.html

+++ b/tracing/tracing/ui/analysis/memory_dump_overview_pane_test.html

@@ -99,7 +99,7 @@ tr.b.unittest.testSuite(function() {

assert.isUndefined(row.subRows);

if (expectedContexts) {

- assert.deepEqual(tr.b.asArray(row.contexts), expectedContexts);

+ assert.deepEqual(Array.from(row.contexts), expectedContexts);

} else {

assert.isUndefined(row.contexts);

}

@@ -440,7 +440,7 @@ tr.b.unittest.testSuite(function() {

const childPane = view.createChildPane();

assert.strictEqual(

childPane.tagName, 'TR-UI-A-MEMORY-DUMP-VM-REGIONS-DETAILS-PANE');

- assert.deepEqual(tr.b.asArray(childPane.vmRegions),

+ assert.deepEqual(Array.from(childPane.vmRegions),

extractVmRegions(processMemoryDumps, 2));

assert.strictEqual(childPane.aggregationMode, AggregationMode.MAX);

});

@@ -461,7 +461,7 @@ tr.b.unittest.testSuite(function() {

const childPane = view.createChildPane();

assert.strictEqual(

childPane.tagName, 'TR-UI-A-MEMORY-DUMP-VM-REGIONS-DETAILS-PANE');

- assert.deepEqual(tr.b.asArray(childPane.vmRegions),

+ assert.deepEqual(Array.from(childPane.vmRegions),

extractVmRegions(processMemoryDumps, 2));

assert.strictEqual(childPane.aggregationMode, AggregationMode.DIFF);

@@ -490,7 +490,7 @@ tr.b.unittest.testSuite(function() {

const childPane = view.createChildPane();

assert.strictEqual(

childPane.tagName, 'TR-UI-A-MEMORY-DUMP-VM-REGIONS-DETAILS-PANE');

- assert.deepEqual(tr.b.asArray(childPane.vmRegions),

+ assert.deepEqual(Array.from(childPane.vmRegions),

extractVmRegions(processMemoryDumps, 1));

assert.strictEqual(childPane.aggregationMode, AggregationMode.MAX);

});