Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(717)

Issue 2955023003: Use POLL* rather than EPOLL* event bits on Fuchsia (Closed)

Created:
3 years, 5 months ago by kulakowski1
Modified:
3 years, 5 months ago
Reviewers:
zra
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Use POLL* rather than EPOLL* event bits on Fuchsia Fuchsia defines these bits identically. We are removing epoll from Fuchsia shortly, so use the <poll.h> ones. R=zra@google.com Committed: https://github.com/dart-lang/sdk/commit/2a9d570f4d43898772c362617f57f086f2ebdc7f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -23 lines) Patch
M runtime/bin/eventhandler_fuchsia.h View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/bin/eventhandler_fuchsia.cc View 5 chunks +14 lines, -14 lines 0 comments Download
M runtime/bin/process_fuchsia.cc View 4 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
kulakowski1
3 years, 5 months ago (2017-06-26 20:39:21 UTC) #1
zra
lgtm
3 years, 5 months ago (2017-06-26 20:49:49 UTC) #2
zra
3 years, 5 months ago (2017-06-26 21:21:34 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
2a9d570f4d43898772c362617f57f086f2ebdc7f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698