third_party/WebKit/Source/core/layout/ng/inline/ng_line_breaker_test.cc - Issue 2954953002: [LayoutNG] Abort a layout once the BFC offset is resolved.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/ng/inline/ng_line_breaker_test.cc

Issue 2954953002: [LayoutNG] Abort a layout once the BFC offset is resolved. (Closed)

Patch Set: rebase. Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/ng/inline/ng_line_breaker.cc ('k') | third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/ng/inline/ng_line_breaker_test.cc

diff --git a/third_party/WebKit/Source/core/layout/ng/inline/ng_line_breaker_test.cc b/third_party/WebKit/Source/core/layout/ng/inline/ng_line_breaker_test.cc

index f9c37cbf04f85688a8f8a29157ffb3db46d775b3..93f1fa8557c29581e06e2e1e9e3fa4a8a121122c 100644

--- a/third_party/WebKit/Source/core/layout/ng/inline/ng_line_breaker_test.cc

+++ b/third_party/WebKit/Source/core/layout/ng/inline/ng_line_breaker_test.cc

@@ -40,7 +40,10 @@ class NGLineBreakerTest : public NGBaseLayoutAlgorithmTest {

NGPhysicalFragment::NGFragmentType::kFragmentBox, node);

container_builder.SetBfcOffset(NGLogicalOffset{LayoutUnit(), LayoutUnit()});

- NGLineBreaker line_breaker(node, space.Get(), &container_builder);

+ Vector<RefPtr<NGUnpositionedFloat>> unpositioned_floats;

+ NGLineBreaker line_breaker(node, space.Get(), &container_builder,

+ &unpositioned_floats);

Vector<NGInlineItemResults> lines;

NGLineInfo line_info;

while (line_breaker.NextLine(&line_info, NGLogicalOffset()))