Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(399)

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_constraint_space.cc

Issue 2954953002: [LayoutNG] Abort a layout once the BFC offset is resolved. (Closed)
Patch Set: ./ Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/ng/ng_constraint_space.cc
diff --git a/third_party/WebKit/Source/core/layout/ng/ng_constraint_space.cc b/third_party/WebKit/Source/core/layout/ng/ng_constraint_space.cc
index 5652b3018a6178d848d1661c3bfd74db287695b3..032ddeb01b5db57bb3cd10435a220c4ef46c47d8 100644
--- a/third_party/WebKit/Source/core/layout/ng/ng_constraint_space.cc
+++ b/third_party/WebKit/Source/core/layout/ng/ng_constraint_space.cc
@@ -100,8 +100,15 @@ RefPtr<NGConstraintSpace> NGConstraintSpace::CreateFromLayoutObject(
fixed_block = true;
}
- bool is_new_fc =
- box.IsLayoutBlock() && ToLayoutBlock(box).CreatesNewFormattingContext();
+ bool is_new_fc = true;
+ // TODO(ikilpatrick): This DCHECK needs to be enabled once we've switched
+ // LayoutTableCell, etc over to LayoutNG.
+ //
+ // We currently need to "force" LayoutNG roots to be formatting contexts so
+ // that floats have layout performed on them.
+ //
+ // DCHECK(is_new_fc,
+ // box.IsLayoutBlock() && ToLayoutBlock(box).CreatesNewFormattingContext());
FloatSize icb_float_size = box.View()->ViewportSizeForViewportUnits();
NGPhysicalSize initial_containing_block_size{

Powered by Google App Engine
This is Rietveld 408576698