[LayoutNG] Abort a layout once the BFC offset is resolved.

third_party/WebKit/Source/core/layout/ng/inline/ng_inline_node.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/layout/ng/inline/ng_inline_node.h"
 
 #include "core/layout/BidiRun.h"
 #include "core/layout/LayoutBlockFlow.h"
 #include "core/layout/LayoutObject.h"
 #include "core/layout/LayoutText.h"
@@ skipping 337 matching lines @@
 
 RefPtr<NGLayoutResult> NGInlineNode::Layout(NGConstraintSpace* constraint_space,
                                             NGBreakToken* break_token) {
   // TODO(kojii): Invalidate PrepareLayout() more efficiently.
   InvalidatePrepareLayout();
   PrepareLayout();
 
   NGInlineLayoutAlgorithm algorithm(*this, constraint_space,
                                     ToNGInlineBreakToken(break_token));
   RefPtr<NGLayoutResult> result = algorithm.Layout();
-  CopyFragmentDataToLayoutBox(*constraint_space, result.Get());
+
+  if (result->Status() == NGLayoutResult::kSuccess &&

[eae, 2017/07/10 23:27:49]

Should we return success even when we failed to position all floats?

[ikilpatrick, 2017/07/11 17:20:41]

This does at the moment, we don't want to "abort" layout if we have unpositioned
floats, e.g.

<div>
  <div id=empty><div id=float></div></div> <!-- this div was "successful" but
has unpositioned floats -->
  <div id=non-empty></div> <!-- this div aborts the layout as first one to
resolve BFC -->

+      result->UnpositionedFloats().IsEmpty())
+    CopyFragmentDataToLayoutBox(*constraint_space, result.Get());
+
   return result;
 }
 
 enum class ContentSizeMode { Max, Sum };
 
 static LayoutUnit ComputeContentSize(NGInlineNode node,
                                      ContentSizeMode mode,
                                      LayoutUnit available_inline_size) {
   const ComputedStyle& style = node.Style();
   NGWritingMode writing_mode = FromPlatformWritingMode(style.GetWritingMode());
 
   RefPtr<NGConstraintSpace> space =
       NGConstraintSpaceBuilder(writing_mode)
           .SetTextDirection(style.Direction())
           .SetAvailableSize({available_inline_size, NGSizeIndefinite})
           .ToConstraintSpace(writing_mode);
 
   NGFragmentBuilder container_builder(
       NGPhysicalFragment::NGFragmentType::kFragmentBox, node);
   container_builder.SetBfcOffset(NGLogicalOffset{LayoutUnit(), LayoutUnit()});
 
-  NGLineBreaker line_breaker(node, space.Get(), &container_builder);
+  Vector<RefPtr<NGUnpositionedFloat>> unpositioned_floats;
+  NGLineBreaker line_breaker(node, space.Get(), &container_builder,
+                             &unpositioned_floats);
+
   NGLineInfo line_info;
   LayoutUnit result;
   while (line_breaker.NextLine(&line_info, NGLogicalOffset())) {
     LayoutUnit inline_size = line_info.TextIndent();
     for (const NGInlineItemResult item_result : line_info.Results())
       inline_size += item_result.inline_size;
     if (mode == ContentSizeMode::Max) {
       result = std::max(inline_size, result);
     } else {
       result += inline_size;
@@ skipping 157 matching lines @@
            item.Style() == item.GetLayoutObject()->Style());
   }
 #endif
 }
 
 String NGInlineNode::ToString() const {
   return String::Format("NGInlineNode");
 }
 
 }  // namespace blink