Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(735)

Unified Diff: webrtc/examples/objc/AppRTCMobile/ARDAppClient.m

Issue 2954903002: Media track ID visibility at BWE level
Patch Set: Media track ID visibility at BWE level Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/examples/objc/AppRTCMobile/ARDAppClient.m
diff --git a/webrtc/examples/objc/AppRTCMobile/ARDAppClient.m b/webrtc/examples/objc/AppRTCMobile/ARDAppClient.m
index 7e9fbdac75dcf6eaa6610bfbe1bcf47b7dfd54bb..c1347f2faad420f5bc68b5bf4bfb231cb117be68 100644
--- a/webrtc/examples/objc/AppRTCMobile/ARDAppClient.m
+++ b/webrtc/examples/objc/AppRTCMobile/ARDAppClient.m
@@ -532,8 +532,7 @@ static int const kKbpsMultiplier = 1000;
constraints:constraints
delegate:self];
// Create AV senders.
- [self createAudioSender];
- [self createVideoSender];
+ [self createMediaSenders];
if (_isInitiator) {
// Send offer.
__weak ARDAppClient *weakSelf = self;
@@ -657,19 +656,6 @@ static int const kKbpsMultiplier = 1000;
}
}
-- (RTCRtpSender *)createVideoSender {
- RTCRtpSender *sender =
- [_peerConnection senderWithKind:kRTCMediaStreamTrackKindVideo
- streamId:kARDMediaStreamId];
- _localVideoTrack = [self createLocalVideoTrack];
- if (_localVideoTrack) {
- sender.track = _localVideoTrack;
- [_delegate appClient:self didReceiveLocalVideoTrack:_localVideoTrack];
- }
-
- return sender;
-}
-
- (void)setMaxBitrateForPeerConnectionVideoSender {
for (RTCRtpSender *sender in _peerConnection.senders) {
if (sender.track != nil) {
@@ -692,16 +678,18 @@ static int const kKbpsMultiplier = 1000;
[sender setParameters:parametersToModify];
}
-- (RTCRtpSender *)createAudioSender {
+- (void)createMediaSenders {
RTCMediaConstraints *constraints = [self defaultMediaAudioConstraints];
RTCAudioSource *source = [_factory audioSourceWithConstraints:constraints];
RTCAudioTrack *track = [_factory audioTrackWithSource:source
trackId:kARDAudioTrackId];
- RTCRtpSender *sender =
- [_peerConnection senderWithKind:kRTCMediaStreamTrackKindAudio
- streamId:kARDMediaStreamId];
- sender.track = track;
- return sender;
+ RTCMediaStream *stream = [_factory mediaStreamWithStreamId:kARDMediaStreamId];
+ [stream addAudioTrack:track];
+ _localVideoTrack = [self createLocalVideoTrack];
+ if(_localVideoTrack) {
+ [stream addVideoTrack:_localVideoTrack];
+ }
+ [_peerConnection addStream:stream];
}
- (RTCVideoTrack *)createLocalVideoTrack {

Powered by Google App Engine
This is Rietveld 408576698