Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Unified Diff: chrome/browser/resources/settings/privacy_page/privacy_page_browser_proxy.js

Issue 2954863003: MD Settings: Convert all browser proxies to use ES6 class syntax. (Closed)
Patch Set: Remove @constructor annotations. Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/privacy_page/privacy_page_browser_proxy.js
diff --git a/chrome/browser/resources/settings/privacy_page/privacy_page_browser_proxy.js b/chrome/browser/resources/settings/privacy_page/privacy_page_browser_proxy.js
index 38f544d52c9411096f46ab10f5649ea627c13c0b..9d384a2bc0b8cd22fa3d28b8b8ec3ffc8a914fb2 100644
--- a/chrome/browser/resources/settings/privacy_page/privacy_page_browser_proxy.js
+++ b/chrome/browser/resources/settings/privacy_page/privacy_page_browser_proxy.js
@@ -9,66 +9,65 @@ var MetricsReporting;
cr.define('settings', function() {
/** @interface */
- function PrivacyPageBrowserProxy() {}
-
- PrivacyPageBrowserProxy.prototype = {
+ class PrivacyPageBrowserProxy {
// <if expr="_google_chrome and not chromeos">
/** @return {!Promise<!MetricsReporting>} */
- getMetricsReporting: assertNotReached,
+ getMetricsReporting() {}
/** @param {boolean} enabled */
- setMetricsReportingEnabled: assertNotReached,
+ setMetricsReportingEnabled(enabled) {}
+
// </if>
// <if expr="is_win or is_macosx">
/** Invokes the native certificate manager (used by win and mac). */
- showManageSSLCertificates: function() {},
+ showManageSSLCertificates() {}
+
// </if>
/** @return {!Promise<boolean>} */
- getSafeBrowsingExtendedReporting: assertNotReached,
+ getSafeBrowsingExtendedReporting() {}
/** @param {boolean} enabled */
- setSafeBrowsingExtendedReportingEnabled: assertNotReached,
- };
+ setSafeBrowsingExtendedReportingEnabled(enabled) {}
+ }
/**
- * @constructor
* @implements {settings.PrivacyPageBrowserProxy}
*/
- function PrivacyPageBrowserProxyImpl() {}
- cr.addSingletonGetter(PrivacyPageBrowserProxyImpl);
-
- PrivacyPageBrowserProxyImpl.prototype = {
+ class PrivacyPageBrowserProxyImpl {
// <if expr="_google_chrome and not chromeos">
/** @override */
- getMetricsReporting: function() {
+ getMetricsReporting() {
return cr.sendWithPromise('getMetricsReporting');
- },
+ }
/** @override */
- setMetricsReportingEnabled: function(enabled) {
+ setMetricsReportingEnabled(enabled) {
chrome.send('setMetricsReportingEnabled', [enabled]);
- },
+ }
+
// </if>
/** @override */
- getSafeBrowsingExtendedReporting: function() {
+ getSafeBrowsingExtendedReporting() {
return cr.sendWithPromise('getSafeBrowsingExtendedReporting');
- },
+ }
/** @override */
- setSafeBrowsingExtendedReportingEnabled: function(enabled) {
+ setSafeBrowsingExtendedReportingEnabled(enabled) {
chrome.send('setSafeBrowsingExtendedReportingEnabled', [enabled]);
- },
+ }
// <if expr="is_win or is_macosx">
/** @override */
- showManageSSLCertificates: function() {
+ showManageSSLCertificates() {
chrome.send('showManageSSLCertificates');
- },
+ }
// </if>
- };
+ }
+
+ cr.addSingletonGetter(PrivacyPageBrowserProxyImpl);
return {
PrivacyPageBrowserProxy: PrivacyPageBrowserProxy,

Powered by Google App Engine
This is Rietveld 408576698