OLD | NEW |
---|---|
(Empty) | |
1 // Copyright 2017 The Chromium Authors. All rights reserved. | |
2 // Use of this source code is governed by a BSD-style license that can be | |
3 // found in the LICENSE file. | |
4 | |
5 #import "ios/chrome/browser/ui/reading_list/text_badge_view.h" | |
6 #import <Foundation/Foundation.h> | |
edchin
2017/06/28 00:38:24
There should be a space after the first import and
helenlyang
2017/06/28 15:25:07
Done.
| |
7 | |
8 #include "testing/gtest/include/gtest/gtest.h" | |
9 #include "testing/gtest_mac.h" | |
edchin
2017/06/28 00:38:24
This has the macro EXPECT_NSEQ(). I'm sure you're
| |
10 | |
11 #if !defined(__has_feature) || !__has_feature(objc_arc) | |
12 #error "This file requires ARC support." | |
13 #endif | |
14 | |
15 // Tests that badge should be hidden if the label is nil. | |
16 TEST(TextBadgeViewTest, BadgeWithoutLabel) {} | |
edchin
2017/06/28 00:38:23
We can remove the first two tests since we think t
helenlyang
2017/06/28 15:25:07
Done.
| |
17 | |
18 // Tests that badge should be hidden if the label text is the empty string. | |
19 TEST(TextBadgeViewTest, EmptyStringLabel) {} | |
20 | |
21 // Tests that badge width should resize to fit short display text. | |
22 TEST(TextBadgeViewTest, BadgeWidthShortLabel) {} | |
edchin
2017/06/28 00:38:23
We can test the intrinsic content size. I like thi
helenlyang
2017/06/28 15:25:07
Done.
| |
23 | |
24 // Tests that badge width should stretch to fit long display text. | |
25 TEST(TextBadgeViewTest, BadgeWidthLongLabel) {} | |
26 | |
27 // Tests that text and layout flip for RTL languages. | |
28 TEST(TextBadgeViewTest, RTL) {} | |
edchin
2017/06/28 00:38:23
This is a good idea. I'm not sure how this is test
| |
29 | |
30 // Tests accessibility features. | |
edchin
2017/06/28 00:38:24
This comment can be more specific. Consider someth
helenlyang
2017/06/28 15:25:07
Done.
| |
31 TEST(TextBadgeViewTest, Accessibility) {} | |
OLD | NEW |