ios/chrome/browser/ui/reading_list/text_badge_view.h - Issue 2954853004: [ios] TextBadgeView interface, implementation, and unit test stubs

Side by Side Diff: ios/chrome/browser/ui/reading_list/text_badge_view.h

Issue 2954853004: [ios] TextBadgeView interface, implementation, and unit test stubs (Closed)

Patch Set: Added unit test stubs. Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

« no previous file with comments | « ios/chrome/browser/ui/reading_list/BUILD.gn ('k') | ios/chrome/browser/ui/reading_list/text_badge_view.mm » ('j') | ios/chrome/browser/ui/reading_list/text_badge_view_unittest.mm » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2017 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef IOS_CHROME_BROWSER_UI_READING_LIST_TEXT_BADGE_VIEW_H_

	6 #define IOS_CHROME_BROWSER_UI_READING_LIST_TEXT_BADGE_VIEW_H_

	7

	8 #import <UIKit/UIKit.h>

	9

	10 // Pill-shaped view that displays white text. The view stretches to fit the
	edchin 2017/06/28 00:38:23 We can emulate UILabel's intrinsic content size. We can emulate UILabel's intrinsic content size. Basically, a label says the size that it wants to be but doesn't actually set its own frame. This doesn't change the interface, but we can remove the comment that the view stretches to fit the content. Read this link for more information: https://developer.apple.com/library/content/documentation/UserExperience/Conc... helenlyang 2017/06/28 15:25:07 Done. Show quoted text On 2017/06/28 00:38:23, edchin wrote: > We can emulate UILabel's intrinsic content size. > Basically, a label says the size that it wants to be > but doesn't actually set its own frame. This doesn't > change the interface, but we can remove the comment > that the view stretches to fit the content. > > Read this link for more information: > https://developer.apple.com/library/content/documentation/UserExperience/Conc... Done.
	11 // display text, and is hidden when the text is the empty string.
	edchin 2017/06/28 00:38:23 We can treat the empty string as programmer error. We can treat the empty string as programmer error. Basically, we feel that the programmer is not properly using this API if they pass in an empty string. Inside the implementation, we can put this line: DCHECK(text); helenlyang 2017/06/28 15:25:07 Done (removed this part of the comment). Show quoted text On 2017/06/28 00:38:23, edchin wrote: > We can treat the empty string as programmer error. > Basically, we feel that the programmer is not properly > using this API if they pass in an empty string. > Inside the implementation, we can put this line: > DCHECK(text); Done (removed this part of the comment).
	12 @interface TextBadgeView : UIView

	13

	14 // Initialize the text badge with the given frame and display text.

	15 - (instancetype)initWithFrame:(CGRect)frame displayText:(NSString*)text;
	edchin 2017/06/28 00:51:14 We should designate this as the initializer. You c We should designate this as the initializer. You can also mark other initializers as unavailable. Here are the ones to mark as unavailable: - initWithFrame:(CGRect)frame; - init; Here's an example: https://cs.chromium.org/chromium/src/ios/chrome/browser/ui/ntp/new_tab_page_v... helenlyang 2017/06/28 15:25:07 Done. I also marked initWithCoder: as unavailable. Show quoted text On 2017/06/28 00:51:14, edchin wrote: > We should designate this as the initializer. You can also mark other > initializers as unavailable. > Here are the ones to mark as unavailable: > - initWithFrame:(CGRect)frame; > - init; > > Here's an example: > https://cs.chromium.org/chromium/src/ios/chrome/browser/ui/ntp/new_tab_page_v... Done. I also marked initWithCoder: as unavailable.
	16

	17 // Display the text badge view. If \|animated\| is true, the badge fades in.
	edchin 2017/06/28 00:38:23 Let's remove this, since it violates the "dumb vie Let's remove this, since it violates the "dumb view" concept. helenlyang 2017/06/28 15:25:07 Done. Show quoted text On 2017/06/28 00:38:23, edchin wrote: > Let's remove this, since it violates the "dumb view" concept. Done.
	18 - (void)presentAnimated:(BOOL)animated;

	19

	20 @end

	21

	22 #endif // IOS_CHROME_BROWSER_UI_READING_LIST_TEXT_BADGE_VIEW_H_

OLD	NEW