ios/chrome/browser/ui/reading_list/text_badge_view.h - Issue 2954853004: [ios] TextBadgeView interface, implementation, and unit test stubs

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ios/chrome/browser/ui/reading_list/text_badge_view.h

Issue 2954853004: [ios] TextBadgeView interface, implementation, and unit test stubs (Closed)

Patch Set: Fixed initializers and unit tests. Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « ios/chrome/browser/ui/reading_list/BUILD.gn ('k') | ios/chrome/browser/ui/reading_list/text_badge_view.mm » ('j') | ios/chrome/browser/ui/reading_list/text_badge_view_unittest.mm » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2017 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef IOS_CHROME_BROWSER_UI_READING_LIST_TEXT_BADGE_VIEW_H_

	6 #define IOS_CHROME_BROWSER_UI_READING_LIST_TEXT_BADGE_VIEW_H_

	7

	8 #import <UIKit/UIKit.h>

	9

	10 // Pill-shaped view that displays white text.

	11 @interface TextBadgeView : UIView

	12

	13 // Initialize the text badge with the given frame and display text.

	14 - (instancetype)initWithFrame:(CGRect)frame
	edchin 2017/06/28 19:54:55 Looking at this a bit more, I think we should remo Looking at this a bit more, I think we should remove the frame and simply have - (instancetype)initWithText:(NSString)text; The reason is that the frame that is passed in will not be used at all. Eventually, the frame will be set again through layout constraints based on the intrinsic content size. gchatz* 2017/06/28 20:10:17 I assume then that you suggest passing CGRectZero Show quoted text On 2017/06/28 19:54:55, edchin wrote: > Looking at this a bit more, I think we should remove the frame and simply > have - (instancetype)initWithText:(NSString*)text; > The reason is that the frame that is passed in will not be used at all. > Eventually, the frame will be set again through layout constraints > based on the intrinsic content size. I assume then that you suggest passing CGRectZero into superclass constructor?
	15 displayText:(NSString*)text NS_DESIGNATED_INITIALIZER;

	16

	17 - (instancetype)initWithFrame:(CGRect)frame NS_UNAVAILABLE;

	18

	19 - (instancetype)initWithCoder:(NSCoder*)aDecoder NS_UNAVAILABLE;

	20

	21 - (instancetype)init NS_UNAVAILABLE;

	22

	23 @end

	24

	25 #endif // IOS_CHROME_BROWSER_UI_READING_LIST_TEXT_BADGE_VIEW_H_

OLD	NEW