Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2954853002: Use Independent URLLoader

Created:
3 years, 5 months ago by yzshen1
Modified:
3 years, 5 months ago
Reviewers:
CC:
chromium-reviews, asanka, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, kinuko+watch, jsbell+serviceworker_chromium.org, tzik, jam, abarth-chromium, darin-cc_chromium.org, loading-reviews_chromium.org, blink-worker-reviews_chromium.org, nhiroki, kinuko, rdsmith+watch_chromium.org, michaeln, shimazu+serviceworker_chromium.org, serviceworker-reviews, Aaron Boodman, kinuko+serviceworker, horo+watch_chromium.org, darin (slow to review), mmenke
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Use Independent URLLoader This CL rebases the CL written by yhirano@chromium.org to ToT. (original CL: https://chromium-review.googlesource.com/c/513643/) This CL removes "associated" for URLLoader in URLLoaderFactory::CreateLoaderAndStart. The associated keyword was needed in order to keep the ordering guarantee which the current ChromeIPC provides, but it is harmful from the network servicification POV. BUG=706286, 724323, 728467

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -100 lines) Patch
M content/browser/appcache/appcache_subresource_url_factory.h View 1 chunk +8 lines, -9 lines 0 comments Download
M content/browser/appcache/appcache_subresource_url_factory.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M content/browser/blob_storage/blob_url_loader_factory.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/blob_storage/blob_url_loader_factory.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M content/browser/blob_storage/blob_url_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/loader/mojo_async_resource_handler.h View 3 chunks +4 lines, -4 lines 0 comments Download
M content/browser/loader/mojo_async_resource_handler.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/loader/mojo_async_resource_handler_unittest.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M content/browser/loader/resource_dispatcher_host_impl.h View 7 chunks +8 lines, -8 lines 0 comments Download
M content/browser/loader/resource_dispatcher_host_impl.cc View 8 chunks +8 lines, -8 lines 0 comments Download
M content/browser/loader/resource_message_filter.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/loader/resource_message_filter.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/loader/resource_request_info_impl.h View 2 chunks +2 lines, -3 lines 0 comments Download
M content/browser/loader/resource_request_info_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/loader/url_loader_factory_impl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/loader/url_loader_factory_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/loader/url_loader_factory_impl_unittest.cc View 9 chunks +9 lines, -9 lines 0 comments Download
M content/browser/service_worker/service_worker_fetch_dispatcher.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/service_worker/service_worker_provider_host.cc View 4 chunks +4 lines, -3 lines 0 comments Download
M content/browser/service_worker/service_worker_url_loader_job.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/site_per_process_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/webui/web_ui_url_loader_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/child/url_loader_client_impl_unittest.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M content/common/throttling_url_loader.h View 2 chunks +1 line, -2 lines 0 comments Download
M content/common/throttling_url_loader.cc View 1 chunk +2 lines, -6 lines 0 comments Download
M content/common/throttling_url_loader_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/url_loader_factory.mojom View 1 chunk +1 line, -1 line 0 comments Download
M content/network/network_service_url_loader_factory_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M content/network/network_service_url_loader_factory_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/network/url_loader_impl.h View 3 chunks +3 lines, -3 lines 0 comments Download
M content/network/url_loader_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/network/url_loader_unittest.cc View 1 2 2 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 11 (11 generated)
yzshen1
The CQ bit was checked by yzshen@chromium.org to run a CQ dry run
3 years, 5 months ago (2017-06-25 18:43:57 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2954853002/1
3 years, 5 months ago (2017-06-25 18:44:01 UTC) #2
yzshen1
Description was changed from ========== Use Independent URLLoader (Original author: yhirano@chromium.org) This CL removes "associated" ...
3 years, 5 months ago (2017-06-25 18:45:34 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 5 months ago (2017-06-25 18:55:10 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_tsan_rel_ng/builds/103552)
3 years, 5 months ago (2017-06-25 18:55:11 UTC) #5
yzshen1
The CQ bit was checked by yzshen@chromium.org to run a CQ dry run
3 years, 5 months ago (2017-06-25 20:07:09 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2954853002/20001
3 years, 5 months ago (2017-06-25 20:07:17 UTC) #7
yzshen1
The CQ bit was checked by yzshen@chromium.org to run a CQ dry run
3 years, 5 months ago (2017-06-25 20:17:02 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2954853002/40001
3 years, 5 months ago (2017-06-25 20:17:09 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 5 months ago (2017-06-25 23:57:47 UTC) #10
commit-bot: I haz the power
3 years, 5 months ago (2017-06-25 23:57:48 UTC) #11 
Dry run: This issue passed the CQ dry run.

Powered by Google App Engine
This is Rietveld 408576698