Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issue 2954843002: Fix upgrading built-in custom elements

Created:
3 years, 6 months ago by Anton Obzhirov
Modified:
3 years, 5 months ago
CC:
blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, dominicc+watchlist_chromium.org, eae+blinkwatch, rwlbuis, sof, webcomponents-bugzilla_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix upgrading built-in custom elements Currently, the built-in elements fail to be tried to upgrade and are not added to upgrade candidates list BUG=618606

Patch Set 1 #

Total comments: 5
Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -2 lines) Patch
M third_party/WebKit/LayoutTests/custom-elements/spec/parsing.html View 2 chunks +70 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Element.cpp View 1 chunk +7 lines, -1 line 2 comments Download
M third_party/WebKit/Source/core/dom/custom/CustomElementRegistry.cpp View 1 chunk +4 lines, -1 line 3 comments Download

Messages

Total messages: 12 (6 generated)
Anton Obzhirov
3 years, 6 months ago (2017-06-25 16:17:58 UTC) #3
dominicc (has gone to gerrit)
Thanks for working on this. I think this needs work, some suggestions inline. https://codereview.chromium.org/2954843002/diff/1/third_party/WebKit/Source/core/dom/Element.cpp File ...
3 years, 5 months ago (2017-06-26 03:03:19 UTC) #6
Anton Obzhirov
Thanks for the review, will update the patch. https://codereview.chromium.org/2954843002/diff/1/third_party/WebKit/Source/core/dom/Element.cpp File third_party/WebKit/Source/core/dom/Element.cpp (right): https://codereview.chromium.org/2954843002/diff/1/third_party/WebKit/Source/core/dom/Element.cpp#newcode1452 third_party/WebKit/Source/core/dom/Element.cpp:1452: if ...
3 years, 5 months ago (2017-06-27 19:19:00 UTC) #9
Anton Obzhirov
https://codereview.chromium.org/2954843002/diff/1/third_party/WebKit/Source/core/dom/custom/CustomElementRegistry.cpp File third_party/WebKit/Source/core/dom/custom/CustomElementRegistry.cpp (left): https://codereview.chromium.org/2954843002/diff/1/third_party/WebKit/Source/core/dom/custom/CustomElementRegistry.cpp#oldcode273 third_party/WebKit/Source/core/dom/custom/CustomElementRegistry.cpp:273: const AtomicString& name = candidate->localName(); On 2017/06/27 19:19:00, Anton ...
3 years, 5 months ago (2017-06-28 14:09:07 UTC) #10
dominicc (has gone to gerrit)
On 2017/06/28 at 14:09:07, a.obzhirov wrote: > https://codereview.chromium.org/2954843002/diff/1/third_party/WebKit/Source/core/dom/custom/CustomElementRegistry.cpp > File third_party/WebKit/Source/core/dom/custom/CustomElementRegistry.cpp (left): > > https://codereview.chromium.org/2954843002/diff/1/third_party/WebKit/Source/core/dom/custom/CustomElementRegistry.cpp#oldcode273 ...
3 years, 5 months ago (2017-06-29 05:39:05 UTC) #11
Anton Obzhirov
3 years, 5 months ago (2017-06-29 07:07:20 UTC) #12
I've uploaded new version to
https://chromium-review.googlesource.com/547715
Plz have a look, I've done some refactoring. The change started to get bigger
then I expected :) Please let me know your thoughts.

Powered by Google App Engine
This is Rietveld 408576698