Issue 295483002: Make sure ReadyStateEnded is fired when video stream stops

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 295483002: Make sure ReadyStateEnded is fired when video stream stops (Closed)

Created:
6 years, 7 months ago by Alpha Left Google

Modified:
6 years, 7 months ago

Reviewers:
perkj_chrome

CC:
chromium-reviews, fischman+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, wjia+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Make sure ReadyStateEnded is fired when video stream stops A regression was introduced in the refactoring change in r269020. VideoCaptureDelegate::started_callback_ is used to notify that the stream has started and ran into error. However in change r269020 the callback was reset after sending the started signal. This prevented error signal from firing. In this change |started_callback_| is renamed to |running_callback| to avoid confusion. Also added a test to verify that ReadyStateEnded is reached when a camera stops. BUG=374495 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271359

Patch Set 1 #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+58 lines, -19 lines)			Patch
M	content/renderer/media/media_stream_video_capture_source_unittest.cc	View	5 chunks	+39 lines, -7 lines	0 comments	Download
M	content/renderer/media/media_stream_video_capturer_source.h	View	4 chunks	+10 lines, -6 lines	0 comments	Download
M	content/renderer/media/media_stream_video_capturer_source.cc	View	3 chunks	+9 lines, -6 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hclam@chromium.org/295483002/1

6 years, 7 months ago (2014-05-19 08:00:28 UTC) #5

Message was sent while issue was closed.

Change committed as 271359

Expand Messages | Collapse Messages