Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 2954693002: Add/fix/cleanup type inference for throw and rethrow. (Closed)

Created:
3 years, 6 months ago by Paul Berry
Modified:
3 years, 6 months ago
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add/fix/cleanup type inference for throw and rethrow. R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/312b4ae52ce5b4b55fc432d115241c78b3c3b7a0

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add a clarifying comment #

Messages

Total messages: 7 (2 generated)
Paul Berry
3 years, 6 months ago (2017-06-23 17:53:55 UTC) #2
Siggi Cherem (dart-lang)
https://codereview.chromium.org/2954693002/diff/1/pkg/front_end/testcases/inference/infer_rethrow.dart File pkg/front_end/testcases/inference/infer_rethrow.dart (right): https://codereview.chromium.org/2954693002/diff/1/pkg/front_end/testcases/inference/infer_rethrow.dart#newcode6 pkg/front_end/testcases/inference/infer_rethrow.dart:6: library test; i'm probably missing something obvious, but what ...
3 years, 6 months ago (2017-06-23 20:49:28 UTC) #3
Paul Berry
PTAL https://codereview.chromium.org/2954693002/diff/1/pkg/front_end/testcases/inference/infer_rethrow.dart File pkg/front_end/testcases/inference/infer_rethrow.dart (right): https://codereview.chromium.org/2954693002/diff/1/pkg/front_end/testcases/inference/infer_rethrow.dart#newcode6 pkg/front_end/testcases/inference/infer_rethrow.dart:6: library test; On 2017/06/23 20:49:27, Siggi Cherem (dart-lang) ...
3 years, 6 months ago (2017-06-23 20:56:49 UTC) #4
Siggi Cherem (dart-lang)
lgtm, thanks!
3 years, 6 months ago (2017-06-23 21:08:48 UTC) #5
Paul Berry
3 years, 6 months ago (2017-06-23 21:33:05 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
312b4ae52ce5b4b55fc432d115241c78b3c3b7a0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698