Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Unified Diff: pkg/compiler/lib/src/ssa/builder_kernel.dart

Issue 2954663002: Handle break as continue (Closed)
Patch Set: Add break/continue to run_from_dill_test Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/ssa/builder_kernel.dart
diff --git a/pkg/compiler/lib/src/ssa/builder_kernel.dart b/pkg/compiler/lib/src/ssa/builder_kernel.dart
index 260b3a3afc1a51a32b77538a786b0e0b07cfea4d..2e49c12ec1a8c98354412e5270508be0136e9c98 100644
--- a/pkg/compiler/lib/src/ssa/builder_kernel.dart
+++ b/pkg/compiler/lib/src/ssa/builder_kernel.dart
@@ -901,11 +901,12 @@ class KernelSsaGraphBuilder extends ir.Visitor
forStatement.body.accept(this);
}
+ JumpTarget jumpTarget = localsMap.getJumpTargetForFor(forStatement);
loopHandler.handleLoop(
forStatement,
localsMap.getClosureRepresentationInfoForLoop(
closureDataLookup, forStatement),
- localsMap.getJumpTargetForFor(forStatement),
+ jumpTarget,
buildInitializer,
buildCondition,
buildUpdate,
@@ -1466,10 +1467,18 @@ class KernelSsaGraphBuilder extends ir.Visitor
assert(target != null);
JumpHandler handler = jumpTargets[target];
assert(handler != null);
- if (handler.labels.isNotEmpty) {
- handler.generateBreak(handler.labels.first);
+ if (localsMap.generateContinueForBreak(breakStatement)) {
+ if (handler.labels.isNotEmpty) {
+ handler.generateContinue(handler.labels.first);
+ } else {
+ handler.generateContinue();
+ }
} else {
- handler.generateBreak();
+ if (handler.labels.isNotEmpty) {
+ handler.generateBreak(handler.labels.first);
+ } else {
+ handler.generateBreak();
+ }
}
}
@@ -1485,8 +1494,14 @@ class KernelSsaGraphBuilder extends ir.Visitor
body.accept(this);
return;
}
- JumpHandler handler = createJumpHandler(
- labeledStatement, localsMap.getJumpTargetForLabel(labeledStatement));
+ JumpTarget jumpTarget = localsMap.getJumpTargetForLabel(labeledStatement);
+ if (jumpTarget == null) {
+ // The label is not needed.
+ body.accept(this);
+ return;
+ }
+
+ JumpHandler handler = createJumpHandler(labeledStatement, jumpTarget);
LocalsHandler beforeLocals = new LocalsHandler.from(localsHandler);
« no previous file with comments | « pkg/compiler/lib/src/kernel/kernel_backend_strategy.dart ('k') | pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698