PlzNavigate: implement REUSE_COMMITTED_OR_PENDING_SITE for redirects

content/browser/frame_host/render_frame_host_manager.h

Index: content/browser/frame_host/render_frame_host_manager.h
diff --git a/content/browser/frame_host/render_frame_host_manager.h b/content/browser/frame_host/render_frame_host_manager.h
index da2d6548129220f1e2606a4acc5efe52b070ddb0..b3071d1b64fcd1c20496d27e8858908db35f8541 100644
--- a/content/browser/frame_host/render_frame_host_manager.h
+++ b/content/browser/frame_host/render_frame_host_manager.h
@@ -505,6 +505,15 @@ class CONTENT_EXPORT RenderFrameHostManager
   bool InitRenderView(RenderViewHostImpl* render_view_host,
     RenderFrameProxyHost* proxy);
 
+  // Returns the SiteInstance that should be used to host the navigation handled
+  // by |navigation_request|.
+  // Note: the SiteInstance returned by this function may not have an initalized

[Charlie Reis, 2017/06/27 04:24:53]

nit: initialized

[clamy, 2017/06/27 15:23:05]

I forgot to address this in the latest patchset. Will do in the next one.

+  // RenderProcessHost. It will only be initialized when GetProcess() is called
+  // on the SiteInstance. In particular, calling this function will never lead
+  // to a process being created for the navigation.

[Charlie Reis, 2017/06/27 04:24:53]

As noted, we might have the option of using SiteInstanceDescriptors here to
avoid side effects, but I'm not sure if that will be sufficient for our needs
(or necessary).

[clamy, 2017/06/27 15:23:05]

I think we want to return the actual SiteInstance if it exists at least. We need
to access its process. If creating a new one is an issue, we could also have a
parameter to not create a SiteInstance if there is none we can use.

+  scoped_refptr<SiteInstance> GetSiteInstanceForNavigationRequest(
+      const NavigationRequest& navigation_request);
+
  private:
   friend class NavigatorTestWithBrowserSideNavigation;
   friend class RenderFrameHostManagerTest;