Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(434)

Unified Diff: content/browser/frame_host/navigation_handle_impl.h

Issue 2954623003: PlzNavigate: implement REUSE_COMMITTED_OR_PENDING_SITE for redirects (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/navigation_handle_impl.h
diff --git a/content/browser/frame_host/navigation_handle_impl.h b/content/browser/frame_host/navigation_handle_impl.h
index f98451b72daee71b3a85188a0ab677595d327159..2df307fc898dfa87fadc86c4157a544c153ec5c5 100644
--- a/content/browser/frame_host/navigation_handle_impl.h
+++ b/content/browser/frame_host/navigation_handle_impl.h
@@ -284,6 +284,7 @@ class CONTENT_EXPORT NavigationHandleImpl : public NavigationHandle {
bool new_is_external_protocol,
scoped_refptr<net::HttpResponseHeaders> response_headers,
net::HttpResponseInfo::ConnectionInfo connection_info,
+ RenderProcessHost* new_expected_render_process_host,
Charlie Reis 2017/06/27 04:24:53 Maybe new_expected_process or post_redirect_proces
clamy 2017/06/27 15:23:05 Done.
const ThrottleChecksFinishedCallback& callback);
// Called when the URLRequest has delivered response headers and metadata.
@@ -430,9 +431,11 @@ class CONTENT_EXPORT NavigationHandleImpl : public NavigationHandle {
// Updates the destination site URL for this navigation. This is called on
// redirects.
- // PlzNavigate: When redirected cross-site, the speculative RenderProcessHost
- // will stop expecting this navigation to commit.
- void UpdateSiteURL();
+ // PlzNavigate: |new_expected_render_process_host_id| is the id of the
+ // renderer process that should handle the navigation following the redirect
+ // if it can be handled by an existing RenderProcessHost. Otherwise, it should
+ // be ChildProcessHost::kInvalidUniqueID.
Charlie Reis 2017/06/27 04:24:53 This comment is talking about IDs, but we pass a R
clamy 2017/06/27 15:23:05 Done.
+ void UpdateSiteURL(RenderProcessHost* new_expected_render_process_host);
// See NavigationHandle for a description of those member variables.
GURL url_;
« no previous file with comments | « no previous file | content/browser/frame_host/navigation_handle_impl.cc » ('j') | content/browser/frame_host/navigation_request.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698