Issue 2954513003: Fix ddc build

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2954513003: Fix ddc build (Closed)

Created:
3 years, 6 months ago by vsm

Modified:
3 years, 6 months ago

Reviewers:
bkonyi, Jennifer Messerly

CC:
dev-compiler+reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Fix ddc build Not sure why this just started breaking. I don't think Ben added this param - just a use of it. Our patch script might not be catching the mismatch. TBR=jmesserly@google.com,bkonyi@google.com Committed: https://github.com/dart-lang/sdk/commit/7d731590174a4132513d4191e34b83c1d147a33f

Patch Set 1 #

Total comments: 1

Created: 3 years, 6 months ago

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	pkg/dev_compiler/lib/sdk/ddc_sdk.sum	View		Binary file		0 comments	Download
	M	pkg/dev_compiler/tool/input_sdk/patch/io_patch.dart	View		1 chunk	+2 lines, -1 line	1 comment	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

vsm

Committed patchset #1 (id:1) manually as 7d731590174a4132513d4191e34b83c1d147a33f (presubmit successful).

3 years, 6 months ago (2017-06-22 21:27:43 UTC) #2

bkonyi

3 years, 6 months ago (2017-06-22 21:30:27 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/2954513003/diff/1/pkg/dev_compiler/tool/input...
File pkg/dev_compiler/tool/input_sdk/patch/io_patch.dart (right):

https://codereview.chromium.org/2954513003/diff/1/pkg/dev_compiler/tool/input...
pkg/dev_compiler/tool/input_sdk/patch/io_patch.dart:431: static Future<Socket>
connect(host, int port, {sourceAddress}) {
There should also be a timeout parameter here. I've also just landed similar
changes for SecureSocket and RawSecureSocket, so they might require similar
changes.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages