Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2954443002: Update co19 to revision dec2b67aaab3bb7339b9764049707e71e601da3d (Closed)

Created:
3 years, 6 months ago by Bill Hesse
Modified:
3 years, 6 months ago
Reviewers:
kustermann
CC:
reviews_dartlang.org, sgrekhov_unipro.ru
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Update co19 to revision dec2b67aaab3bb7339b9764049707e71e601da3d BUG= R=kustermann@google.com Committed: https://github.com/dart-lang/sdk/commit/232684aac0fdf44e14e735d28f7c5b7fb9e21235

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -116 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M tests/co19/co19-analyzer2.status View 1 chunk +4 lines, -5 lines 0 comments Download
M tests/co19/co19-co19.status View 2 chunks +0 lines, -11 lines 0 comments Download
M tests/co19/co19-dart2js.status View 27 chunks +26 lines, -48 lines 2 comments Download
M tests/co19/co19-dartium.status View 17 chunks +5 lines, -38 lines 0 comments Download
M tests/co19/co19-runtime.status View 3 chunks +9 lines, -11 lines 0 comments Download
M tools/deps/dartium.deps/DEPS View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Bill Hesse
3 years, 6 months ago (2017-06-22 09:40:24 UTC) #1
kustermann
lgtm https://codereview.chromium.org/2954443002/diff/1/tests/co19/co19-dart2js.status File tests/co19/co19-dart2js.status (right): https://codereview.chromium.org/2954443002/diff/1/tests/co19/co19-dart2js.status#newcode790 tests/co19/co19-dart2js.status:790: WebPlatformTest/html/syntax/parsing/Document.getElementsByTagName-foreign_t01: RuntimeError, Pass Why these flaky markers?
3 years, 6 months ago (2017-06-22 09:42:34 UTC) #2
Bill Hesse
https://codereview.chromium.org/2954443002/diff/1/tests/co19/co19-dart2js.status File tests/co19/co19-dart2js.status (right): https://codereview.chromium.org/2954443002/diff/1/tests/co19/co19-dart2js.status#newcode790 tests/co19/co19-dart2js.status:790: WebPlatformTest/html/syntax/parsing/Document.getElementsByTagName-foreign_t01: RuntimeError, Pass On 2017/06/22 09:42:33, kustermann wrote: > ...
3 years, 6 months ago (2017-06-22 09:46:00 UTC) #3
Bill Hesse
3 years, 6 months ago (2017-06-22 09:46:20 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
232684aac0fdf44e14e735d28f7c5b7fb9e21235 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698