third_party/WebKit/Source/core/layout/ng/ng_block_node_test.cc - Issue 2954433003: [LayoutNG] Make leading OOF objects not to create context

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_block_node_test.cc

Issue 2954433003: [LayoutNG] Make leading OOF objects not to create context

Patch Set: Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm_test.cc ('k') | third_party/WebKit/Source/core/layout/ng/ng_out_of_flow_layout_part_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/ng/ng_block_node_test.cc

diff --git a/third_party/WebKit/Source/core/layout/ng/ng_block_node_test.cc b/third_party/WebKit/Source/core/layout/ng/ng_block_node_test.cc

index 8f79055f77d9f523cf0693e1373148e0b05e13cd..673b0c1fbadaf9a88786f139fcb0934f7c7386cd 100644

--- a/third_party/WebKit/Source/core/layout/ng/ng_block_node_test.cc

+++ b/third_party/WebKit/Source/core/layout/ng/ng_block_node_test.cc

@@ -73,9 +73,9 @@ TEST_F(NGBlockNodeForTest, ChildFloatBeforeInline) {

)HTML");

NGBlockNode container(ToLayoutBox(GetLayoutObjectByElementId("container")));

NGLayoutInputNode child1 = container.FirstChild();

- EXPECT_TRUE(child1 && child1.IsBlock());

+ EXPECT_TRUE(child1 && child1.IsInline());

NGLayoutInputNode child2 = child1.NextSibling();

- EXPECT_TRUE(child2 && child2.IsBlock());

+ EXPECT_EQ(child2, nullptr);

}

TEST_F(NGBlockNodeForTest, ChildFloatAfterInline) {

@@ -103,7 +103,7 @@ TEST_F(NGBlockNodeForTest, ChildFloatOnly) {

)HTML");

NGBlockNode container(ToLayoutBox(GetLayoutObjectByElementId("container")));

NGLayoutInputNode child1 = container.FirstChild();

- EXPECT_TRUE(child1 && child1.IsBlock());

+ EXPECT_TRUE(child1 && child1.IsInline());

NGLayoutInputNode child2 = child1.NextSibling();

EXPECT_EQ(child2, nullptr);

}

@@ -120,7 +120,7 @@ TEST_F(NGBlockNodeForTest, ChildFloatWithSpaces) {

)HTML");

NGBlockNode container(ToLayoutBox(GetLayoutObjectByElementId("container")));

NGLayoutInputNode child1 = container.FirstChild();

- EXPECT_TRUE(child1 && child1.IsBlock());

+ EXPECT_TRUE(child1 && child1.IsInline());

NGLayoutInputNode child2 = child1.NextSibling();

EXPECT_EQ(child2, nullptr);

}

@@ -135,9 +135,9 @@ TEST_F(NGBlockNodeForTest, ChildOofBeforeInline) {

)HTML");

NGBlockNode container(ToLayoutBox(GetLayoutObjectByElementId("container")));

NGLayoutInputNode child1 = container.FirstChild();

- EXPECT_TRUE(child1 && child1.IsBlock());

+ EXPECT_TRUE(child1 && child1.IsInline());

NGLayoutInputNode child2 = child1.NextSibling();

- EXPECT_TRUE(child2 && child2.IsBlock());

+ EXPECT_EQ(child2, nullptr);

}

TEST_F(NGBlockNodeForTest, ChildOofAfterInline) {