services/resource_coordinator/coordination_unit/process_coordination_unit_impl_unittest.cc - Issue 2954413004: [GRC] Tab-level CPU Attribution

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: services/resource_coordinator/coordination_unit/process_coordination_unit_impl_unittest.cc

Issue 2954413004: [GRC] Tab-level CPU Attribution (Closed)

Patch Set: Rebase Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « services/resource_coordinator/coordination_unit/process_coordination_unit_impl.cc ('k') | services/resource_coordinator/coordination_unit/web_contents_coordination_unit_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: services/resource_coordinator/coordination_unit/process_coordination_unit_impl_unittest.cc

diff --git a/services/resource_coordinator/coordination_unit/process_coordination_unit_impl_unittest.cc b/services/resource_coordinator/coordination_unit/process_coordination_unit_impl_unittest.cc

index 30e9e1d145d7e63d5735bb819d5285219e4e4263..292b86f9d2186fc48ec8118c03c2c91f39b4f0f3 100644

--- a/services/resource_coordinator/coordination_unit/process_coordination_unit_impl_unittest.cc

+++ b/services/resource_coordinator/coordination_unit/process_coordination_unit_impl_unittest.cc

@@ -9,6 +9,7 @@

#include "services/resource_coordinator/coordination_unit/coordination_unit_impl_unittest_util.h"

#include "services/resource_coordinator/public/cpp/coordination_unit_id.h"

#include "services/resource_coordinator/public/cpp/coordination_unit_types.h"

+#include "services/resource_coordinator/public/interfaces/coordination_unit.mojom.h"

#include "testing/gtest/include/gtest/gtest.h"

namespace resource_coordinator {

@@ -29,7 +30,9 @@ TEST_F(ProcessCoordinationUnitImplTest, MeasureCPUUsage) {

base::RunLoop().RunUntilIdle();

- EXPECT_LE(0.0, coordination_unit_->GetCPUUsageForTesting());

+ base::Value cpu_usage_value =

+ coordination_unit_->GetProperty(mojom::PropertyType::kCPUUsage);

+ EXPECT_LE(0.0, cpu_usage_value.GetDouble());

}

} // namespace resource_coordinator