Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1250)

Unified Diff: services/resource_coordinator/coordination_unit/coordination_unit_impl.cc

Issue 2954413004: [GRC] Tab-level CPU Attribution (Closed)
Patch Set: Rebase Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: services/resource_coordinator/coordination_unit/coordination_unit_impl.cc
diff --git a/services/resource_coordinator/coordination_unit/coordination_unit_impl.cc b/services/resource_coordinator/coordination_unit/coordination_unit_impl.cc
index 277e110a1f5c9e88290022b5c26fa42ddc81c43a..50b6628ef2ac224e82a5413b1594ee90905a12cb 100644
--- a/services/resource_coordinator/coordination_unit/coordination_unit_impl.cc
+++ b/services/resource_coordinator/coordination_unit/coordination_unit_impl.cc
@@ -26,9 +26,6 @@ CUIDMap& g_cu_map() {
} // namespace
-const double CoordinationUnitImpl::kCPUUsageMinimumForTesting = 0.0;
-const double CoordinationUnitImpl::kCPUUsageUnmeasuredForTesting = -1.0;
-
CoordinationUnitImpl::CoordinationUnitImpl(
const CoordinationUnitID& id,
std::unique_ptr<service_manager::ServiceContextRef> service_ref)
@@ -262,8 +259,49 @@ void CoordinationUnitImpl::UnregisterCoordinationPolicyCallback() {
current_policy_.reset();
}
-double CoordinationUnitImpl::GetCPUUsageForTesting() {
- return kCPUUsageUnmeasuredForTesting;
+std::set<CoordinationUnitImpl*>
+CoordinationUnitImpl::GetChildCoordinationUnitsOfType(
+ CoordinationUnitType type) {
+ std::set<CoordinationUnitImpl*> coordination_units;
+
+ for (auto* child : children()) {
+ if (child->id().type == type) {
+ coordination_units.insert(child);
+ }
+
+ for (auto* coordination_unit :
+ child->GetChildCoordinationUnitsOfType(type)) {
+ coordination_units.insert(coordination_unit);
+ }
+ }
+
+ return coordination_units;
+}
+
+std::set<CoordinationUnitImpl*>
+CoordinationUnitImpl::GetParentCoordinationUnitsOfType(
+ CoordinationUnitType type) {
+ std::set<CoordinationUnitImpl*> coordination_units;
+
+ for (auto* parent : parents()) {
+ if (parent->id().type == type) {
+ coordination_units.insert(parent);
+ }
+
+ for (auto* coordination_unit :
+ parent->GetParentCoordinationUnitsOfType(type)) {
+ coordination_units.insert(coordination_unit);
+ }
+ }
+
+ return coordination_units;
+}
+
+std::set<CoordinationUnitImpl*>
+CoordinationUnitImpl::GetAssociatedCoordinationUnitsOfType(
+ CoordinationUnitType type) {
+ NOTREACHED();
+ return std::set<CoordinationUnitImpl*>();
}
base::Value CoordinationUnitImpl::GetProperty(
@@ -313,4 +351,32 @@ void CoordinationUnitImpl::RemoveObserver(
observers_.RemoveObserver(observer);
}
+// static
+bool CoordinationUnitImpl::IsCoordinationUnitType(
+ const CoordinationUnitImpl* coordination_unit,
+ CoordinationUnitType type) {
+ return coordination_unit->id().type == type;
+}
+
+// static
+bool CoordinationUnitImpl::IsFrameCoordinationUnit(
+ const CoordinationUnitImpl* coordination_unit) {
+ return IsCoordinationUnitType(coordination_unit,
+ CoordinationUnitType::kFrame);
+}
+
+// static
+bool CoordinationUnitImpl::IsProcessCoordinationUnit(
+ const CoordinationUnitImpl* coordination_unit) {
+ return IsCoordinationUnitType(coordination_unit,
+ CoordinationUnitType::kProcess);
+}
+
+// static
+bool CoordinationUnitImpl::IsWebContentsCoordinationUnit(
+ const CoordinationUnitImpl* coordination_unit) {
+ return IsCoordinationUnitType(coordination_unit,
+ CoordinationUnitType::kWebContents);
+}
+
} // namespace resource_coordinator

Powered by Google App Engine
This is Rietveld 408576698