Add type inference for super method invocations.

Add type inference for super method invocations.

I implemented the correct logic for both SuperMethodInvocation and
DirectMethodInvocation, since there are TODO comments in the code
indicating that the former will be replaced by the latter when
possible.

R=scheglov@google.com

Committed: https://github.com/dart-lang/sdk/commit/e24eab66d96999389926752efdbb97d370009665

[Paul Berry, 2017-06-26 18:57:54]

paulberry@google.com changed reviewers:
+ ahe@google.com, scheglov@google.com, sigmund@google.com

[Paul Berry, 2017-06-26 18:57:55]

I only need a review from one of you.

Peter, I have a specific question for you below, however since tests pass and
I'm fairly certain the code is correct, I might go ahead and land it before I
hear from you.  Let me know if there's a problem and I'll be happy to fix it
ASAP.

https://codereview.chromium.org/2954403002/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/kernel/body_builder.dart (right):

https://codereview.chromium.org/2954403002/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/kernel/body_builder.dart:907: new
KernelSuperMethodInvocation(node.name, node.arguments, target)
Peter, can you confirm that passing `target` is the correct thing to do here?

[scheglov, 2017-06-26 19:36:31]

LGTM

[Paul Berry, 2017-06-26 19:42:50]

Description was changed from

==========
Add type inference for super method invocations.

I implemented the correct logic for both SuperMethodInvocation and
DirectMethodInvocation, since there are TODO comments in the code
indicating that the former will be replaced by the latter when
possible.
==========

to

==========
Add type inference for super method invocations.

I implemented the correct logic for both SuperMethodInvocation and
DirectMethodInvocation, since there are TODO comments in the code
indicating that the former will be replaced by the latter when
possible.

R=scheglov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/e24eab66d96999389926752efdbb97d370009665
==========

[Paul Berry, 2017-06-26 19:42:51]

Committed patchset #1 (id:1) manually as
e24eab66d96999389926752efdbb97d370009665 (presubmit successful).

[Siggi Cherem (dart-lang), 2017-06-26 19:47:53]

https://codereview.chromium.org/2954403002/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/kernel/body_builder.dart (right):

https://codereview.chromium.org/2954403002/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/kernel/body_builder.dart:907: new
KernelSuperMethodInvocation(node.name, node.arguments, target)
On 2017/06/26 18:57:55, Paul Berry wrote:
> Peter, can you confirm that passing `target` is the correct thing to do here?

DBC - the answer might change in the near future when we address
https://github.com/dart-lang/sdk/issues/30000. I expect we will generate
super-calls with a null target on purpose in those cases.

[Paul Berry, 2017-06-27 20:50:17]

https://codereview.chromium.org/2954403002/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/kernel/body_builder.dart (right):

https://codereview.chromium.org/2954403002/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/kernel/body_builder.dart:907: new
KernelSuperMethodInvocation(node.name, node.arguments, target)
On 2017/06/26 19:47:53, Siggi Cherem (dart-lang) wrote:
> On 2017/06/26 18:57:55, Paul Berry wrote:
> > Peter, can you confirm that passing `target` is the correct thing to do
here?
> 
> DBC - the answer might change in the near future when we address
> https://github.com/dart-lang/sdk/issues/30000. I expect we will generate
> super-calls with a null target on purpose in those cases.

Thanks for the heads up.  I'm adding a test case to make sure type inference
won't break in those cases (https://codereview.chromium.org/2958113002/).