chrome/android/javatests/src/org/chromium/chrome/browser/tabmodel/TabModelSelectorTabModelObserverTest.java - Issue 2954393003: Fix test crashes related to AccountManagerHelper.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/tabmodel/TabModelSelectorTabModelObserverTest.java

Issue 2954393003: Fix test crashes related to AccountManagerHelper. (Closed)

Patch Set: . Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/javatests/src/org/chromium/chrome/browser/tabmodel/TabModelSelectorObserverTestRule.java ('k') | chrome/android/javatests/src/org/chromium/chrome/browser/tabmodel/TabModelSelectorTabObserverTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/javatests/src/org/chromium/chrome/browser/tabmodel/TabModelSelectorTabModelObserverTest.java

diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/tabmodel/TabModelSelectorTabModelObserverTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/tabmodel/TabModelSelectorTabModelObserverTest.java

index 197641c8177591732e2c13afcead08aca85cd63f..1c1c604bcb9b0413e03b66661164e5f9a8b98e9c 100644

--- a/chrome/android/javatests/src/org/chromium/chrome/browser/tabmodel/TabModelSelectorTabModelObserverTest.java

+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/tabmodel/TabModelSelectorTabModelObserverTest.java

@@ -15,7 +15,6 @@ import org.junit.Test;

import org.junit.rules.RuleChain;

import org.junit.runner.RunWith;

-import org.chromium.base.annotations.SuppressFBWarnings;

import org.chromium.base.test.BaseJUnit4ClassRunner;

import org.chromium.base.test.util.CallbackHelper;

import org.chromium.chrome.browser.tab.Tab;

@@ -32,11 +31,11 @@ import java.util.concurrent.TimeoutException;

@RunWith(BaseJUnit4ClassRunner.class)

public class TabModelSelectorTabModelObserverTest {

// Do not add @Rule to this, it's already added to RuleChain

- private TabModelSelectorObserverTestRule mTestRule = new TabModelSelectorObserverTestRule();

+ private final TabModelSelectorObserverTestRule mTestRule =

+ new TabModelSelectorObserverTestRule();

- @SuppressFBWarnings("URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD")

@Rule

- public RuleChain mChain = RuleChain.outerRule(mTestRule).around(new UiThreadTestRule());

+ public final RuleChain mChain = RuleChain.outerRule(mTestRule).around(new UiThreadTestRule());

private TabModelSelectorBase mSelector;