Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2188)

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/sync/ui/PassphraseActivityTest.java

Issue 2954393003: Fix test crashes related to AccountManagerHelper. (Closed)
Patch Set: . Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/javatests/src/org/chromium/chrome/browser/sync/ui/PassphraseActivityTest.java
diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/sync/ui/PassphraseActivityTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/sync/ui/PassphraseActivityTest.java
index 334868676ea90125171dc905c7363230e2c9abe6..73b6a7cf45e3fd02cae3351536b08e80bb49f46a 100644
--- a/chrome/android/javatests/src/org/chromium/chrome/browser/sync/ui/PassphraseActivityTest.java
+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/sync/ui/PassphraseActivityTest.java
@@ -17,6 +17,7 @@ import org.junit.Assert;
import org.junit.Before;
import org.junit.Rule;
import org.junit.Test;
+import org.junit.rules.RuleChain;
import org.junit.runner.RunWith;
import org.chromium.base.ThreadUtils;
@@ -25,10 +26,10 @@ import org.chromium.base.test.util.Feature;
import org.chromium.base.test.util.RetryOnFailure;
import org.chromium.chrome.browser.sync.FakeProfileSyncService;
import org.chromium.chrome.browser.sync.ProfileSyncService;
-import org.chromium.chrome.test.util.ApplicationData;
+import org.chromium.chrome.browser.test.ChromeBrowserTestRule;
+import org.chromium.chrome.browser.test.ClearAppDataTestRule;
import org.chromium.chrome.test.util.browser.signin.SigninTestUtil;
import org.chromium.components.signin.ChromeSigninController;
-import org.chromium.content.browser.test.NativeLibraryTestRule;
/**
* Tests for PassphraseActivity.
@@ -36,24 +37,20 @@ import org.chromium.content.browser.test.NativeLibraryTestRule;
@RunWith(BaseJUnit4ClassRunner.class)
public class PassphraseActivityTest {
@Rule
- public NativeLibraryTestRule mActivityTestRule = new NativeLibraryTestRule();
+ public final RuleChain mChain =
+ RuleChain.outerRule(new ClearAppDataTestRule()).around(new ChromeBrowserTestRule());
private Context mContext;
@Before
public void setUp() throws Exception {
mContext = InstrumentationRegistry.getInstrumentation().getTargetContext();
- SigninTestUtil.setUpAuthForTest(InstrumentationRegistry.getInstrumentation());
- ApplicationData.clearAppData(mContext);
- mActivityTestRule.loadNativeLibraryAndInitBrowserProcess();
}
@After
public void tearDown() throws Exception {
// Clear ProfileSyncService in case it was mocked.
ProfileSyncService.overrideForTests(null);
- SigninTestUtil.resetSigninState();
- SigninTestUtil.tearDownAuthForTest();
}
/**
@@ -117,4 +114,4 @@ public class PassphraseActivityTest {
}
});
}
-}
+}

Powered by Google App Engine
This is Rietveld 408576698