Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(839)

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/search_engines/TemplateUrlServiceTest.java

Issue 2954393003: Fix test crashes related to AccountManagerHelper. (Closed)
Patch Set: . Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/javatests/src/org/chromium/chrome/browser/search_engines/TemplateUrlServiceTest.java
diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/search_engines/TemplateUrlServiceTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/search_engines/TemplateUrlServiceTest.java
index 027b3efd31e1b45d31ca599b3ebb7570e58ef98c..a8ef79a459a6711738863e8b9fa2d348c039ccc7 100644
--- a/chrome/android/javatests/src/org/chromium/chrome/browser/search_engines/TemplateUrlServiceTest.java
+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/search_engines/TemplateUrlServiceTest.java
@@ -5,13 +5,12 @@
package org.chromium.chrome.browser.search_engines;
import android.net.Uri;
-import android.support.test.InstrumentationRegistry;
import android.support.test.filters.SmallTest;
import org.junit.Assert;
-import org.junit.Before;
import org.junit.Rule;
import org.junit.Test;
+import org.junit.rules.RuleChain;
import org.junit.runner.RunWith;
import org.chromium.base.ThreadUtils;
@@ -21,9 +20,9 @@ import org.chromium.base.test.util.Restriction;
import org.chromium.base.test.util.RetryOnFailure;
import org.chromium.chrome.browser.search_engines.TemplateUrlService.LoadListener;
import org.chromium.chrome.browser.search_engines.TemplateUrlService.TemplateUrl;
-import org.chromium.chrome.test.util.ApplicationData;
+import org.chromium.chrome.browser.test.ChromeBrowserTestRule;
+import org.chromium.chrome.browser.test.ClearAppDataTestRule;
import org.chromium.chrome.test.util.ChromeRestriction;
-import org.chromium.content.browser.test.NativeLibraryTestRule;
import org.chromium.content.browser.test.util.Criteria;
import org.chromium.content.browser.test.util.CriteriaHelper;
@@ -38,7 +37,8 @@ import java.util.concurrent.atomic.AtomicBoolean;
@RunWith(BaseJUnit4ClassRunner.class)
public class TemplateUrlServiceTest {
@Rule
- public NativeLibraryTestRule mActivityTestRule = new NativeLibraryTestRule();
+ public final RuleChain mChain =
+ RuleChain.outerRule(new ClearAppDataTestRule()).around(new ChromeBrowserTestRule());
private static final String QUERY_PARAMETER = "q";
private static final String QUERY_VALUE = "cat";
@@ -53,13 +53,6 @@ public class TemplateUrlServiceTest {
private static final String PREFETCH_PARAMETER = "pf";
private static final String PREFETCH_VALUE = "c";
- @Before
- public void setUp() throws Exception {
- ApplicationData.clearAppData(
- InstrumentationRegistry.getInstrumentation().getTargetContext());
- mActivityTestRule.loadNativeLibraryAndInitBrowserProcess();
- }
-
@Test
@SmallTest
@Feature({"ContextualSearch"})

Powered by Google App Engine
This is Rietveld 408576698