Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/preferences/PreferencesTest.java

Issue 2954393003: Fix test crashes related to AccountManagerHelper. (Closed)
Patch Set: . Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/javatests/src/org/chromium/chrome/browser/preferences/PreferencesTest.java
diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/preferences/PreferencesTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/preferences/PreferencesTest.java
index b77fc616924f7658e4bf2ed5af6db6959a4c63e7..e7fb6b3e1467ef78a60f8749c45acd0706341076 100644
--- a/chrome/android/javatests/src/org/chromium/chrome/browser/preferences/PreferencesTest.java
+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/preferences/PreferencesTest.java
@@ -15,7 +15,6 @@ import android.support.test.InstrumentationRegistry;
import android.support.test.filters.SmallTest;
import org.junit.Assert;
-import org.junit.Before;
import org.junit.Rule;
import org.junit.Test;
import org.junit.runner.RunWith;
@@ -34,7 +33,7 @@ import org.chromium.chrome.browser.preferences.website.WebsitePreferenceBridge;
import org.chromium.chrome.browser.search_engines.TemplateUrlService;
import org.chromium.chrome.browser.search_engines.TemplateUrlService.LoadListener;
import org.chromium.chrome.browser.search_engines.TemplateUrlService.TemplateUrl;
-import org.chromium.content.browser.test.NativeLibraryTestRule;
+import org.chromium.chrome.browser.test.ChromeBrowserTestRule;
import org.chromium.content.browser.test.util.UiUtils;
import java.lang.reflect.InvocationTargetException;
@@ -48,12 +47,7 @@ import java.util.List;
@RunWith(BaseJUnit4ClassRunner.class)
public class PreferencesTest {
@Rule
- public NativeLibraryTestRule mActivityTestRule = new NativeLibraryTestRule();
-
- @Before
- public void setUp() throws Exception {
- mActivityTestRule.loadNativeLibraryAndInitBrowserProcess();
- }
+ public final ChromeBrowserTestRule mBrowserTestRule = new ChromeBrowserTestRule();
/**
* Launches the preferences menu and starts the preferences activity named fragmentName.
@@ -106,16 +100,8 @@ public class PreferencesTest {
SearchEnginePreference pref =
(SearchEnginePreference) prefActivity.getFragmentForTest();
pref.setValueForTesting("1");
- }
- });
-
- ThreadUtils.runOnUiThreadBlocking(new Runnable() {
- @Override
- public void run() {
// Ensure that the second search engine in the list is selected.
- SearchEnginePreference pref =
- (SearchEnginePreference) prefActivity.getFragmentForTest();
Assert.assertNotNull(pref);
Assert.assertEquals("1", pref.getValueForTesting());

Powered by Google App Engine
This is Rietveld 408576698