Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3090)

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/autofill/PersonalDataManagerTest.java

Issue 2954393003: Fix test crashes related to AccountManagerHelper. (Closed)
Patch Set: . Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/javatests/src/org/chromium/chrome/browser/autofill/PersonalDataManagerTest.java
diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/autofill/PersonalDataManagerTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/autofill/PersonalDataManagerTest.java
index 6417f5ab25685d9fa09cded906b9395a268fe927..137cc72e52c82e5aa929b172c8483fff15152140 100644
--- a/chrome/android/javatests/src/org/chromium/chrome/browser/autofill/PersonalDataManagerTest.java
+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/autofill/PersonalDataManagerTest.java
@@ -4,13 +4,13 @@
package org.chromium.chrome.browser.autofill;
-import android.support.test.InstrumentationRegistry;
import android.support.test.filters.SmallTest;
import org.junit.Assert;
import org.junit.Before;
import org.junit.Rule;
import org.junit.Test;
+import org.junit.rules.RuleChain;
import org.junit.runner.RunWith;
import org.chromium.base.test.BaseJUnit4ClassRunner;
@@ -18,8 +18,8 @@ import org.chromium.base.test.util.Feature;
import org.chromium.base.test.util.RetryOnFailure;
import org.chromium.chrome.browser.autofill.PersonalDataManager.AutofillProfile;
import org.chromium.chrome.browser.autofill.PersonalDataManager.CreditCard;
-import org.chromium.chrome.test.util.ApplicationData;
-import org.chromium.content.browser.test.NativeLibraryTestRule;
+import org.chromium.chrome.browser.test.ChromeBrowserTestRule;
+import org.chromium.chrome.browser.test.ClearAppDataTestRule;
import java.util.LinkedList;
import java.util.List;
@@ -32,16 +32,13 @@ import java.util.concurrent.TimeoutException;
@RunWith(BaseJUnit4ClassRunner.class)
public class PersonalDataManagerTest {
@Rule
- public NativeLibraryTestRule mActivityTestRule = new NativeLibraryTestRule();
+ public final RuleChain mChain =
+ RuleChain.outerRule(new ClearAppDataTestRule()).around(new ChromeBrowserTestRule());
private AutofillTestHelper mHelper;
@Before
- public void setUp() throws Exception {
- ApplicationData.clearAppData(
- InstrumentationRegistry.getInstrumentation().getTargetContext());
- mActivityTestRule.loadNativeLibraryAndInitBrowserProcess();
-
+ public void setUp() {
mHelper = new AutofillTestHelper();
}

Powered by Google App Engine
This is Rietveld 408576698