Fixed AudioInputController muted state related tsan bug.

Fixed AudioInputController muted state related tsan bug.

Closed in favor of https://codereview.chromium.org/2958003002/

BUG=chromium:736268
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

[ossu-chromium, 2017-06-26 12:55:22]

Description was changed from

==========
Fixed AudioInputController muted state related tsan bug.

BUG=chromium:736268
==========

to

==========
Fixed AudioInputController muted state related tsan bug.

BUG=chromium:736268
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[ossu-chromium, 2017-06-26 12:55:30]

The CQ bit was checked by ossu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-26 12:55:42]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ossu-chromium, 2017-06-26 14:55:54]

The CQ bit was checked by ossu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-26 14:56:08]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ossu-chromium, 2017-06-26 16:11:54]

ossu@chromium.org changed reviewers:
+ dalecurtis@chromium.org

[ossu-chromium, 2017-06-26 16:11:55]

Seems the concurrency issues I was having with keeping the timer as a regular
member variable, in my previous CL, cropped up again. I've put the timer in an
optional again, as suggested by maxmorin@. That way, we don't have to do a
separate heap allocation for it (c.f. unique_ptr), but can still create/destroy
it at will.

PTAL.

[DaleCurtis, 2017-06-26 16:51:41]

I don't think this is correct, or at least the explanation for what's happening
isn't right, can you elaborate some more so I can understand? See
base::Timer::Stop() will detach from the sequence imposed by timer, 

https://cs.chromium.org/chromium/src/base/timer/timer.cc?sq=package:chromium&...

Something else is going on if that destruction check is failing.

[commit-bot: I haz the power, 2017-06-26 17:16:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-26 17:16:18]

Dry run: This issue passed the CQ dry run.

[ossu-chromium, 2017-06-27 09:54:41]

On 2017/06/26 16:51:41, DaleCurtis wrote:
> I don't think this is correct, or at least the explanation for what's
happening
> isn't right, can you elaborate some more so I can understand? See
> base::Timer::Stop() will detach from the sequence imposed by timer, 
> 
>
https://cs.chromium.org/chromium/src/base/timer/timer.cc?sq=package:chromium&...
> 
> Something else is going on if that destruction check is failing.

Ah, yes, it's not the destruction check, but a race between
BaseTimerTaskInternal::Run and BaseTimerTaskInternal::Abandon. It might actually
be a fault with that implementation - I'll see if I can fix it at the source.

[ossu-chromium, 2017-06-27 15:49:34]

On 2017/06/27 09:54:41, ossu-chromium wrote:
> On 2017/06/26 16:51:41, DaleCurtis wrote:
> > I don't think this is correct, or at least the explanation for what's
> happening
> > isn't right, can you elaborate some more so I can understand? See
> > base::Timer::Stop() will detach from the sequence imposed by timer, 
> > 
> >
>
https://cs.chromium.org/chromium/src/base/timer/timer.cc?sq=package:chromium&...
> > 
> > Something else is going on if that destruction check is failing.
> 
> Ah, yes, it's not the destruction check, but a race between
> BaseTimerTaskInternal::Run and BaseTimerTaskInternal::Abandon. It might
actually
> be a fault with that implementation - I'll see if I can fix it at the source.

Trying to address the underlying problem in Timer instead in:
https://codereview.chromium.org/2958003002/

[ossu-chromium, 2017-07-06 08:58:55]

Description was changed from

==========
Fixed AudioInputController muted state related tsan bug.

BUG=chromium:736268
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Fixed AudioInputController muted state related tsan bug.

Closed in favor of https://codereview.chromium.org/2958003002/

BUG=chromium:736268
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========