Source/core/animation/AnimatableValue.h - Issue 29543005: Introduce DEFINE_ANIMATABLE_VALUE_TYPE_CASTS to replace manual toFoo() for animatable value

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/core/animation/AnimatableValue.h

Issue 29543005: Introduce DEFINE_ANIMATABLE_VALUE_TYPE_CASTS to replace manual toFoo() for animatable value (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2013 Google Inc. All rights reserved.	2 * Copyright (C) 2013 Google Inc. All rights reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions are	5 * modification, are permitted provided that the following conditions are

6 * met:	6 * met:

7 *	7 *

8 * * Redistributions of source code must retain the above copyright	8 * * Redistributions of source code must retain the above copyright

9 * notice, this list of conditions and the following disclaimer.	9 * notice, this list of conditions and the following disclaimer.

10 * * Redistributions in binary form must reproduce the above	10 * * Redistributions in binary form must reproduce the above

(...skipping 105 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
116	116

117 template <class T>	117 template <class T>

118 static PassRefPtr<T> takeConstRef(const T* value) { return PassRefPtr<T>(con st_cast<T*>(value)); }	118 static PassRefPtr<T> takeConstRef(const T* value) { return PassRefPtr<T>(con st_cast<T*>(value)); }

119	119

120 private:	120 private:

121 virtual AnimatableType type() const = 0;	121 virtual AnimatableType type() const = 0;

122 // Implementations can assume that the object being compared has the same ty pe as the object this is called on	122 // Implementations can assume that the object being compared has the same ty pe as the object this is called on

123 virtual bool equalTo(const AnimatableValue*) const = 0;	123 virtual bool equalTo(const AnimatableValue*) const = 0;

124 };	124 };

125	125

	126 #define DEFINE_ANIMATABLE_VALUE_TYPE_CASTS(thisType, predicate) \

	127 DEFINE_TYPE_CASTS(thisType, AnimatableValue, value, value->predicate, value. predicate)

	128

126 } // namespace WebCore	129 } // namespace WebCore

127	130

128 #endif // AnimatableValue_h	131 #endif // AnimatableValue_h

OLD	NEW

« Source/core/animation/AnimatableRepeatable.h ('K') | « Source/core/animation/AnimatableUnknown.h ('k') | Source/core/animation/AnimatableVisibility.h » ('j') | no next file with comments »