Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2954283002: Status file update for skipping_dart2js_compilations. (Closed)

Created:
3 years, 5 months ago by devoncarew
Modified:
3 years, 5 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Status file update for skipping_dart2js_compilations. BUG= R=vegorov@google.com Committed: https://github.com/dart-lang/sdk/commit/e38488aa0d66711af73d945ebcb4cf38c72412c6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M tests/standalone/io/skipping_dart2js_compilations_test.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M tests/standalone/standalone.status View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
devoncarew
Partial rollback of the status file update in https://github.com/dart-lang/sdk/commit/dd5c779b4359004e63103449a9357d9b8c2715ed - there's still one failing test. ...
3 years, 5 months ago (2017-06-26 04:56:45 UTC) #2
Vyacheslav Egorov (Google)
lgtm
3 years, 5 months ago (2017-06-26 13:47:34 UTC) #4
devoncarew
Committed patchset #1 (id:1) manually as e38488aa0d66711af73d945ebcb4cf38c72412c6 (presubmit successful).
3 years, 5 months ago (2017-06-26 13:50:44 UTC) #6
Bob Nystrom
3 years, 5 months ago (2017-06-27 00:41:28 UTC) #7
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698