Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issue 2954253002: Add type inference for while and do loops. (Closed)

Created:
3 years, 6 months ago by Paul Berry
Modified:
3 years, 5 months ago
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add type inference for while and do loops. Analyzer does not type infer these constructs correctly (it uses an empty context for the loop condition, instead of bool), so the tests are in inference_new. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/213c2080a53d3c9ef2a9ade8ef083aba0777e544

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+149 lines, -3 lines) Patch
M pkg/front_end/lib/src/fasta/kernel/body_builder.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart View 2 chunks +30 lines, -0 lines 0 comments Download
M pkg/front_end/lib/src/fasta/type_inference/type_inference_listener.dart View 2 chunks +12 lines, -0 lines 0 comments Download
M pkg/front_end/testcases/implicit_scope_test.dart.strong.expect View 1 chunk +1 line, -1 line 0 comments Download
A pkg/front_end/testcases/inference_new/do_loop.dart View 1 chunk +16 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference_new/do_loop.dart.direct.expect View 1 chunk +13 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference_new/do_loop.dart.outline.expect View 1 chunk +10 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference_new/do_loop.dart.strong.expect View 1 chunk +13 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference_new/while_loop.dart View 1 chunk +16 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference_new/while_loop.dart.direct.expect View 1 chunk +12 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference_new/while_loop.dart.outline.expect View 1 chunk +10 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference_new/while_loop.dart.strong.expect View 1 chunk +12 lines, -0 lines 0 comments Download
M pkg/front_end/testcases/kompile.status View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
I only need a review from one of you. This is not urgent--feel free to ...
3 years, 6 months ago (2017-06-25 15:41:18 UTC) #2
scheglov
LGTM
3 years, 5 months ago (2017-06-26 15:08:48 UTC) #3
Paul Berry
3 years, 5 months ago (2017-06-26 16:07:33 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
213c2080a53d3c9ef2a9ade8ef083aba0777e544 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698