Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(380)

Issue 295423005: Fix the documentation in sessions API. (Closed)

Created:
6 years, 7 months ago by wjywbs
Modified:
6 years, 7 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Fix the documentation in sessions API. Add info for when sessionId is not provided in the restore function. R=kalman@chromium.org BUG=377607 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273028

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/common/extensions/api/sessions.json View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
wjywbs
PTAL. After this CL, I can not find any more issues with this API. Thanks.
6 years, 7 months ago (2014-05-27 03:13:13 UTC) #1
not at google - send to devlin
lgtm
6 years, 7 months ago (2014-05-27 16:42:00 UTC) #2
wjywbs
The CQ bit was checked by wjywbs@gmail.com
6 years, 7 months ago (2014-05-27 17:52:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wjywbs@gmail.com/295423005/1
6 years, 7 months ago (2014-05-27 17:53:39 UTC) #4
commit-bot: I haz the power
Change committed as 273028
6 years, 7 months ago (2014-05-27 21:05:06 UTC) #5
wjywbs
6 years, 7 months ago (2014-05-27 21:49:51 UTC) #6
Message was sent while issue was closed.
Hello kalman, could you do a final review and post a final review thread on
apps-dev? Thanks.

Powered by Google App Engine
This is Rietveld 408576698