Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Unified Diff: public/platform/WebCryptoAlgorithmOperation.h

Issue 295423004: Expose WebCrypto's algorithm normalization. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebased, minor cleanups. Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: public/platform/WebCryptoAlgorithmOperation.h
diff --git a/public/platform/WebConnectionType.h b/public/platform/WebCryptoAlgorithmOperation.h
similarity index 81%
copy from public/platform/WebConnectionType.h
copy to public/platform/WebCryptoAlgorithmOperation.h
index db5b2aac298271f647a60b6ff6e8a30a2ef99ee3..501e6222a1d11e4a5bb6b0cd54ef92ec80f55cb6 100644
--- a/public/platform/WebConnectionType.h
+++ b/public/platform/WebCryptoAlgorithmOperation.h
@@ -28,22 +28,27 @@
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*/
-#ifndef WebConnectionType_h
-#define WebConnectionType_h
+#ifndef WebCryptoAlgorithmOperation_h
+#define WebCryptoAlgorithmOperation_h
namespace blink {
-// Connection types from http://w3c.github.io/netinfo/.
-enum WebConnectionType {
- ConnectionTypeCellular = 0,
- ConnectionTypeBluetooth,
- ConnectionTypeEthernet,
- ConnectionTypeWifi,
- ConnectionTypeOther,
- ConnectionTypeNone,
- ConnectionTypeLast = ConnectionTypeNone
+enum AlgorithmOperation {
+ Encrypt,
jochen (gone - plz use gerrit) 2014/06/02 09:01:45 public enums should start with Web, I'd put Crypto
pneubeck (no reviews) 2014/06/02 13:54:25 Done. Moved to WebCryptoAlgorithm
+ Decrypt,
+ Sign,
+ Verify,
+ Digest,
+ GenerateKey,
+ ImportKey,
+ DeriveKey,
+ DeriveBits,
+ WrapKey,
+ UnwrapKey,
+ // <---- End of list (keep this up-to-date)
jochen (gone - plz use gerrit) 2014/06/02 09:01:45 that comment is unnecessary
pneubeck (no reviews) 2014/06/02 13:54:25 Done.
+ LastAlgorithmOperation = UnwrapKey,
jochen (gone - plz use gerrit) 2014/06/02 09:01:45 Should be WebCryptoAlgorithmOperationLast
pneubeck (no reviews) 2014/06/02 13:54:25 Done.
};
} // namespace blink
-#endif // WebConnectionType_h
+#endif

Powered by Google App Engine
This is Rietveld 408576698