Add AnalysisSession to analyzer

Add AnalysisSession to analyzer

R=scheglov@google.com

Committed: https://github.com/dart-lang/sdk/commit/5946ce552f25dec9bbf37a39d1c92d60bf64597c

[Brian Wilkerson, 2017-06-23 17:39:31]

brianwilkerson@google.com changed reviewers:
+ scheglov@google.com

[Brian Wilkerson, 2017-06-23 17:39:32]

This adds an initial implementation of AnalysisSession and makes it available
from the analysis result objects. This doesn't include the new definition of
AnalysisContext, but that's still planned.

[scheglov, 2017-06-26 15:30:03]

LGTM

https://codereview.chromium.org/2954153002/diff/1/pkg/analyzer/lib/dart/analy...
File pkg/analyzer/lib/dart/analysis/session.dart (right):

https://codereview.chromium.org/2954153002/diff/1/pkg/analyzer/lib/dart/analy...
pkg/analyzer/lib/dart/analysis/session.dart:18: * InconsistentAnalysisException
if the result to be returned might be
Maybe [InconsistentAnalysisException] to make it indexable.

https://codereview.chromium.org/2954153002/diff/1/pkg/analyzer/lib/src/dart/a...
File pkg/analyzer/lib/src/dart/analysis/driver.dart (right):

https://codereview.chromium.org/2954153002/diff/1/pkg/analyzer/lib/src/dart/a...
pkg/analyzer/lib/src/dart/analysis/driver.dart:1693: final AnalysisSession
session;
This field should be the first.

https://codereview.chromium.org/2954153002/diff/1/pkg/analyzer/lib/src/dart/a...
File pkg/analyzer/lib/src/dart/analysis/session.dart (right):

https://codereview.chromium.org/2954153002/diff/1/pkg/analyzer/lib/src/dart/a...
pkg/analyzer/lib/src/dart/analysis/session.dart:19: *
InconsistentAnalysisException if the result to be returned might be
Unless we add something new about details of implementation, it does not seem
useful to repeat the documentation of the interface.

https://codereview.chromium.org/2954153002/diff/1/pkg/analyzer/lib/src/dart/a...
pkg/analyzer/lib/src/dart/analysis/session.dart:22: class
DriverBasedAnalysisSession implements AnalysisSession {
It sounds like we might have different implementations.

If we don't, maybe name it just AnalysisSessionImpl?

https://codereview.chromium.org/2954153002/diff/1/pkg/analyzer/lib/src/dart/a...
pkg/analyzer/lib/src/dart/analysis/session.dart:47: LibraryElement coreLibrary =
await _driver.getLibraryByUri('dart:core');
This is a bit suboptimal - we will resynthesize the second copy of code library.
We could optionally pass TypeProvider into the session constructor.
In the most cases we compute resolved AST and we know TypeProvider.

https://codereview.chromium.org/2954153002/diff/1/pkg/analyzer/lib/src/dart/a...
pkg/analyzer/lib/src/dart/analysis/session.dart:117: * Check to see that results
from this class will be consistent, and throw an
class -> session

[Brian Wilkerson, 2017-06-26 16:06:19]

https://codereview.chromium.org/2954153002/diff/1/pkg/analyzer/lib/dart/analy...
File pkg/analyzer/lib/dart/analysis/session.dart (right):

https://codereview.chromium.org/2954153002/diff/1/pkg/analyzer/lib/dart/analy...
pkg/analyzer/lib/dart/analysis/session.dart:18: * InconsistentAnalysisException
if the result to be returned might be
Done

https://codereview.chromium.org/2954153002/diff/1/pkg/analyzer/lib/src/dart/a...
File pkg/analyzer/lib/src/dart/analysis/driver.dart (right):

https://codereview.chromium.org/2954153002/diff/1/pkg/analyzer/lib/src/dart/a...
pkg/analyzer/lib/src/dart/analysis/driver.dart:1693: final AnalysisSession
session;
Done

https://codereview.chromium.org/2954153002/diff/1/pkg/analyzer/lib/src/dart/a...
File pkg/analyzer/lib/src/dart/analysis/session.dart (right):

https://codereview.chromium.org/2954153002/diff/1/pkg/analyzer/lib/src/dart/a...
pkg/analyzer/lib/src/dart/analysis/session.dart:19: *
InconsistentAnalysisException if the result to be returned might be
Done

https://codereview.chromium.org/2954153002/diff/1/pkg/analyzer/lib/src/dart/a...
pkg/analyzer/lib/src/dart/analysis/session.dart:22: class
DriverBasedAnalysisSession implements AnalysisSession {
Done

https://codereview.chromium.org/2954153002/diff/1/pkg/analyzer/lib/src/dart/a...
pkg/analyzer/lib/src/dart/analysis/session.dart:47: LibraryElement coreLibrary =
await _driver.getLibraryByUri('dart:core');
> This is a bit suboptimal - we will resynthesize the second copy of code
library.
> We could optionally pass TypeProvider into the session constructor.
> In the most cases we compute resolved AST and we know TypeProvider.

I would love to see this improved, but as it is currently implemented, we don't
have a TypeProvider at the point at which the session is being created. If we
delay creating the session until after we've performed an analysis, then we
could optimize this. I think I'll save that work for a follow-on CL.

https://codereview.chromium.org/2954153002/diff/1/pkg/analyzer/lib/src/dart/a...
pkg/analyzer/lib/src/dart/analysis/session.dart:117: * Check to see that results
from this class will be consistent, and throw an
Done

[Brian Wilkerson, 2017-06-26 16:16:16]

Description was changed from

==========
Add AnalysisSession to analyzer
==========

to

==========
Add AnalysisSession to analyzer

R=scheglov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/5946ce552f25dec9bbf37a39d1c92d60bf64597c
==========

[Brian Wilkerson, 2017-06-26 16:16:18]

Committed patchset #1 (id:1) manually as
5946ce552f25dec9bbf37a39d1c92d60bf64597c (presubmit successful).