Remove special casing of == null

Remove special casing of == null

This avoid reversing the operands for `null == x`
- and make Hello World! fully equivalent.

R=sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/ecb5767bbadac644b5d64cfdc56b71df627ba697

[Johnni Winther, 2017-06-23 14:12:17]

johnniwinther@google.com changed reviewers:
+ sigmund@google.com

[Siggi Cherem (dart-lang), 2017-06-23 20:43:37]

lgtm with comments

https://codereview.chromium.org/2954123002/diff/1/pkg/compiler/lib/src/ssa/ke...
File pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart (right):

https://codereview.chromium.org/2954123002/diff/1/pkg/compiler/lib/src/ssa/ke...
pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart:585: return
closedWorld.commonMasks.dynamicType;
should we list here what kind of `send` we expect here. For example, I imagine
we only want to include null-aware sends?

https://codereview.chromium.org/2954123002/diff/1/tests/compiler/dart2js/kern...
File tests/compiler/dart2js/kernel/compile_from_dill_test.dart (right):

https://codereview.chromium.org/2954123002/diff/1/tests/compiler/dart2js/kern...
tests/compiler/dart2js/kernel/compile_from_dill_test.dart:55: var w = x == null
? null : x.toString();
with your change, is `x ?? y` and `x ??= y` handled as well?

[Johnni Winther, 2017-06-26 10:47:26]

Description was changed from

==========
Remove special casing of == null

This avoid reversing the operands for `null == x`
- and make Hello World! fully equivalent.
==========

to

==========
Remove special casing of == null

This avoid reversing the operands for `null == x`
- and make Hello World! fully equivalent.

R=sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/ecb5767bbadac644b5d64cfdc56b71df627ba697
==========

[Johnni Winther, 2017-06-26 10:47:28]

Committed patchset #3 (id:40001) manually as
ecb5767bbadac644b5d64cfdc56b71df627ba697 (presubmit successful).

[Johnni Winther, 2017-06-26 10:47:40]

https://codereview.chromium.org/2954123002/diff/1/pkg/compiler/lib/src/ssa/ke...
File pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart (right):

https://codereview.chromium.org/2954123002/diff/1/pkg/compiler/lib/src/ssa/ke...
pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart:585: return
closedWorld.commonMasks.dynamicType;
On 2017/06/23 20:43:37, Siggi Cherem (dart-lang) wrote:
> should we list here what kind of `send` we expect here. For example, I imagine
> we only want to include null-aware sends?

Asserted that `send.name.name == 'null'`.

https://codereview.chromium.org/2954123002/diff/1/tests/compiler/dart2js/kern...
File tests/compiler/dart2js/kernel/compile_from_dill_test.dart (right):

https://codereview.chromium.org/2954123002/diff/1/tests/compiler/dart2js/kern...
tests/compiler/dart2js/kernel/compile_from_dill_test.dart:55: var w = x == null
? null : x.toString();
On 2017/06/23 20:43:37, Siggi Cherem (dart-lang) wrote:
> with your change, is `x ?? y` and `x ??= y` handled as well?

Yes. Tests added.