Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 2954113002: Rebased simplify CompilerConfiguration (Closed)

Created:
3 years, 6 months ago by Bill Hesse
Modified:
3 years, 6 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Rebased simplify CompilerConfiguration BUG= Committed: https://github.com/dart-lang/sdk/commit/6482690781c44ded82495d9bb523379283fe958a

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+137 lines, -345 lines) Patch
M tools/testing/dart/compiler_configuration.dart View 32 chunks +137 lines, -345 lines 4 comments Download

Messages

Total messages: 7 (2 generated)
Bill Hesse
This is your CL, rebased to tip-of-tree. I will fix the merge errors and address ...
3 years, 6 months ago (2017-06-23 12:01:35 UTC) #2
Bill Hesse
I will test and land, since it is basically your CL with LGTM from me. ...
3 years, 6 months ago (2017-06-23 12:06:43 UTC) #3
Bill Hesse
Committed patchset #1 (id:1) manually as 6482690781c44ded82495d9bb523379283fe958a (presubmit successful).
3 years, 6 months ago (2017-06-23 12:10:15 UTC) #5
Bill Hesse
TBR=rnystrom@google.com
3 years, 6 months ago (2017-06-23 12:17:41 UTC) #6
Bob Nystrom
3 years, 6 months ago (2017-06-23 17:57:00 UTC) #7
Message was sent while issue was closed.
LGTM, thanks!

Powered by Google App Engine
This is Rietveld 408576698