Add a unit test for translation event logging.

chrome/browser/translate/chrome_translate_client_unittest.cc

Index: chrome/browser/translate/chrome_translate_client_unittest.cc
diff --git a/chrome/browser/translate/chrome_translate_client_unittest.cc b/chrome/browser/translate/chrome_translate_client_unittest.cc
index 18f9cf9723143b832067d93aeff9003a6c7914a2..3117e88018aa27b756e4388248239457262076f8 100644
--- a/chrome/browser/translate/chrome_translate_client_unittest.cc
+++ b/chrome/browser/translate/chrome_translate_client_unittest.cc
@@ -5,6 +5,8 @@
 #include "chrome/browser/translate/chrome_translate_client.h"
 
 #include <memory>
+#include <string>
+#include <vector>
 
 #include "base/command_line.h"
 #include "base/memory/ref_counted.h"
@@ -13,6 +15,7 @@
 #include "chrome/browser/sync/profile_sync_service_factory.h"
 #include "chrome/browser/sync/user_event_service_factory.h"
 #include "chrome/test/base/chrome_render_view_host_test_harness.h"
+#include "components/metrics/proto/translate_event.pb.h"
 #include "components/sync/driver/sync_driver_switches.h"
 #include "components/sync/user_events/fake_user_event_service.h"
 #include "components/translate/core/common/language_detection_details.h"
@@ -20,11 +23,24 @@
 #include "testing/gtest/include/gtest/gtest.h"
 #include "url/gurl.h"
 
+using ::metrics::TranslateEventProto;

[Matt Giuca, 2017/06/29 00:26:51]

I don't think it's worth using this for just 2 mentions in the whole file. Can
you just fully qualify the name below?

[renjieliu1, 2017/06/29 01:09:06]

Done.

+
 std::unique_ptr<KeyedService> BuildFakeUserEventService(
     content::BrowserContext* context) {
   return base::MakeUnique<syncer::FakeUserEventService>();
 }
 
+TranslateEventProto BuildTranslateEventProto(
+    const std::string& from,
+    const std::string& to,
+    const TranslateEventProto::EventType type) {
+  TranslateEventProto event;
+  event.set_source_language(from);
+  event.set_target_language(to);
+  event.set_event_type(type);
+  return event;
+}
+
 class ChromeTranslateClientTest : public ChromeRenderViewHostTestHarness {
  public:
   void SetUp() override {
@@ -34,8 +50,10 @@ class ChromeTranslateClientTest : public ChromeRenderViewHostTestHarness {
             ->SetTestingFactoryAndUse(browser_context(),
                                       &BuildFakeUserEventService));
     scoped_feature_list_ = base::MakeUnique<base::test::ScopedFeatureList>();
-    scoped_feature_list_->InitAndEnableFeature(
-        switches::kSyncUserLanguageDetectionEvents);
+    scoped_feature_list_->InitWithFeatures(
+        {switches::kSyncUserLanguageDetectionEvents,
+         switches::kSyncUserTranslationEvents},
+        {});
   }
 
   void TearDown() override { ChromeRenderViewHostTestHarness::TearDown(); }
@@ -51,7 +69,7 @@ class ChromeTranslateClientTest : public ChromeRenderViewHostTestHarness {
 };
 
 TEST_F(ChromeTranslateClientTest, LanguageEventShouldRecord) {
-  GURL url("http://yahoo.com");
+  const GURL url("http://yahoo.com");
   NavigateAndCommit(url);
   ChromeTranslateClient client(web_contents());
   translate::LanguageDetectionDetails details;
@@ -63,7 +81,7 @@ TEST_F(ChromeTranslateClientTest, LanguageEventShouldRecord) {
 }
 
 TEST_F(ChromeTranslateClientTest, LanguageEventShouldNotRecord) {
-  GURL url("about://blank");
+  const GURL url("about://blank");
   NavigateAndCommit(url);
   ChromeTranslateClient client(web_contents());
   translate::LanguageDetectionDetails details;
@@ -73,3 +91,34 @@ TEST_F(ChromeTranslateClientTest, LanguageEventShouldNotRecord) {
   client.OnLanguageDetermined(details);
   EXPECT_EQ(0u, GetUserEventService()->GetRecordedUserEvents().size());
 }
+
+TEST_F(ChromeTranslateClientTest, TranslationEventShouldRecord) {
+  const GURL url("http://yahoo.com");
+  NavigateAndCommit(url);
+  ChromeTranslateClient client(web_contents());
+  // Event we care.

[Matt Giuca, 2017/06/29 00:26:51]

What does this comment mean? "An event we care about." maybe?

[renjieliu1, 2017/06/29 01:09:06]

good suggestion!

+  const TranslateEventProto& event_proto =
+      BuildTranslateEventProto("ja", "en", TranslateEventProto::USER_ACCEPT);
+  client.RecordTranslateEvent(event_proto);
+  EXPECT_EQ(1ul, GetUserEventService()->GetRecordedUserEvents().size());
+
+  sync_pb::Translation expected_translation_event;
+  expected_translation_event.set_from_language_code("ja");
+  expected_translation_event.set_to_language_code("en");
+  expected_translation_event.set_interaction(sync_pb::Translation::ACCEPT);
+  const auto& result_translation_event =
+      GetUserEventService()->GetRecordedUserEvents()[0].translation();
+  EXPECT_EQ(expected_translation_event.SerializeAsString(),
+            result_translation_event.SerializeAsString());
+}
+
+TEST_F(ChromeTranslateClientTest, TranslationEventShouldNotRecord) {
+  const GURL url("http://yahoo.com");
+  NavigateAndCommit(url);
+  ChromeTranslateClient client(web_contents());
+  // Event we don't care.

[Matt Giuca, 2017/06/29 00:26:51]

Same.

[renjieliu1, 2017/06/29 01:09:06]

Done.

+  const TranslateEventProto& event_proto = BuildTranslateEventProto(
+      "ja", "en", TranslateEventProto::UNSUPPORTED_URL);
+  client.RecordTranslateEvent(event_proto);
+  EXPECT_EQ(0u, GetUserEventService()->GetRecordedUserEvents().size());
+}