Cherry-pick upstream r237929

Cherry-pick upstream r237929

Itanium mangler: don't trip an assertion when unresolved members have implicit bases.

R=sbc@chromium.org

When we find a member of the current instantation, the base of the
unresolved member expression is implicit; use nullptr for such
bases. This is not a change in behavior: the AST already contains null
in such cases, so non-asserts builds do the right thing already. Fixes
rdar://problem/21020559.
Committed: cfbfff6970d1fc876a6ed3f04289e3086c9a9129

[Derek Schuff, 2017-06-23 22:27:55]

dschuff@chromium.org changed reviewers:
+ sbc@chromium.org

[Derek Schuff, 2017-06-23 22:30:09]

Description was changed from

==========
Cherry-pick upstream r237929

Itanium mangler: don't trip an assertion when unresolved members have implicit
bases.

When we find a member of the current instantation, the base of the
unresolved member expression is implicit; use nullptr for such
bases. This is not a change in behavior: the AST already contains null
in such cases, so non-asserts builds do the right thing already. Fixes
rdar://problem/21020559.



BUG=

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@237929
91177308-0d34-0410-b5e6-96231b3b80d8
==========

to

==========
Cherry-pick upstream r237929

Itanium mangler: don't trip an assertion when unresolved members have implicit
bases.

When we find a member of the current instantation, the base of the
unresolved member expression is implicit; use nullptr for such
bases. This is not a change in behavior: the AST already contains null
in such cases, so non-asserts builds do the right thing already. Fixes
rdar://problem/21020559.
==========

[Sam Clegg, 2017-06-23 22:38:16]

Wow.. impressed that you found this.

[Sam Clegg, 2017-06-23 22:38:21]

lgtm

[Derek Schuff, 2017-06-23 22:46:11]

On 2017/06/23 22:38:16, Sam Clegg wrote:
> Wow.. impressed that you found this.

No magic really. I repro'd the failure with upstream clang, and bisected
clang+llvm and got close to the right change, and then you can sort of tell by
looking at failure output that it was this assert.

[Derek Schuff, 2017-06-24 01:03:40]

Description was changed from

==========
Cherry-pick upstream r237929

Itanium mangler: don't trip an assertion when unresolved members have implicit
bases.

When we find a member of the current instantation, the base of the
unresolved member expression is implicit; use nullptr for such
bases. This is not a change in behavior: the AST already contains null
in such cases, so non-asserts builds do the right thing already. Fixes
rdar://problem/21020559.
==========

to

==========
Cherry-pick upstream r237929

Itanium mangler: don't trip an assertion when unresolved members have implicit
bases.

R=sbc@chromium.org

When we find a member of the current instantation, the base of the
unresolved member expression is implicit; use nullptr for such
bases. This is not a change in behavior: the AST already contains null
in such cases, so non-asserts builds do the right thing already. Fixes
rdar://problem/21020559.
Committed: cfbfff6970d1fc876a6ed3f04289e3086c9a9129
==========

[Derek Schuff, 2017-06-24 01:03:41]

Committed patchset #1 (id:1) manually as
cfbfff6970d1fc876a6ed3f04289e3086c9a9129 (presubmit successful).