Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(603)

Issue 295403002: Factor bindings.gypi (Closed)

Created:
6 years, 7 months ago by Nils Barth (inactive)
Modified:
6 years, 7 months ago
CC:
blink-reviews, blink-reviews-bindings_chromium.org, arv+blink, abarth-chromium
Visibility:
Public.

Description

Factor bindings.gypi Prep for splitting bindings GYP files. Currently bindings.gypi has a single long, qualified list of files. It's simpler to put these in separate lists per directory, which also lets the filenames be just the basename (unqualified). This will simplify splitting into core vs. modules, and also makes file organization more modular. Tweaks to core.gyp: the excess directories in 'include_dirs' are part of what I'll fix. R=haraken BUG=358074 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174780

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add license #

Unified diffs Side-by-side diffs Delta from patch set Stats (+271 lines, -238 lines) Patch
M Source/bindings/bindings.gypi View 1 1 chunk +8 lines, -235 lines 0 comments Download
A Source/bindings/v8/custom/custom.gypi View 1 chunk +93 lines, -0 lines 0 comments Download
A Source/bindings/v8/v8.gypi View 1 chunk +167 lines, -0 lines 0 comments Download
M Source/core/core.gyp View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Nils Barth (inactive)
Preliminary CL
6 years, 7 months ago (2014-05-26 01:46:32 UTC) #1
kouhei (in TOK)
lgtm
6 years, 7 months ago (2014-05-26 01:49:43 UTC) #2
haraken
LGTM https://codereview.chromium.org/295403002/diff/1/Source/bindings/bindings.gypi File Source/bindings/bindings.gypi (right): https://codereview.chromium.org/295403002/diff/1/Source/bindings/bindings.gypi#newcode1 Source/bindings/bindings.gypi:1: { Shall we have a copyright on this ...
6 years, 7 months ago (2014-05-26 02:42:31 UTC) #3
Nils Barth (inactive)
Fixed, thanks! https://codereview.chromium.org/295403002/diff/1/Source/bindings/bindings.gypi File Source/bindings/bindings.gypi (right): https://codereview.chromium.org/295403002/diff/1/Source/bindings/bindings.gypi#newcode1 Source/bindings/bindings.gypi:1: { On 2014/05/26 02:42:32, haraken wrote: > ...
6 years, 7 months ago (2014-05-26 02:44:10 UTC) #4
Nils Barth (inactive)
The CQ bit was checked by nbarth@chromium.org
6 years, 7 months ago (2014-05-26 02:44:21 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/295403002/20001
6 years, 7 months ago (2014-05-26 02:44:36 UTC) #6
commit-bot: I haz the power
6 years, 7 months ago (2014-05-26 04:00:37 UTC) #7
Message was sent while issue was closed.
Change committed as 174780

Powered by Google App Engine
This is Rietveld 408576698