Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 2954013002: [LayoutNG] Fix positioning of zero-block-size-div, and content size. (Closed)

Created:
3 years, 6 months ago by ikilpatrick
Modified:
3 years, 6 months ago
Reviewers:
cbiesinger, eae
CC:
chromium-reviews, cbiesinger, ojan+watch_chromium.org, szager+layoutwatch_chromium.org, glebl+reviews_chromium.org, dgrogan+ng_chromium.org, atotic+reviews_chromium.org, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, zoltan1, jchaffraix+rendering, blink-reviews, lchoi+reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[LayoutNG] Fix positioning of zero-block-size-div, and content size. This patch does a few small things: - Removes adding the end margin for a zero-block-size-div for positioning (which was incorrect). - Calculate the final content_size_ based off the previous inflow position. (If it was -ve, we'd overestimate the height). - Clarified a few comments. BUG=635619 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng Review-Url: https://codereview.chromium.org/2954013002 Cr-Commit-Position: refs/heads/master@{#482017} Committed: https://chromium.googlesource.com/chromium/src/+/07a754c70339bd975c433dfe344f003eaeaa8cc3

Patch Set 1 #

Patch Set 2 : lalala. #

Patch Set 3 : try try try #

Patch Set 4 : \o/ #

Patch Set 5 : add failures for bot. #

Patch Set 6 : rebase... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+109 lines, -19 lines) Patch
M third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG View 1 2 3 4 5 2 chunks +5 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/TestExpectations View 1 2 3 4 5 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc View 1 2 3 5 chunks +30 lines, -17 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm_test.cc View 1 chunk +74 lines, -0 lines 0 comments Download

Messages

Total messages: 31 (24 generated)
ikilpatrick
3 years, 6 months ago (2017-06-23 16:11:39 UTC) #15
ikilpatrick
This removes all of the times we were using content_size_ incorrectly \o/
3 years, 6 months ago (2017-06-23 16:11:59 UTC) #17
eae
LGTM \o/
3 years, 6 months ago (2017-06-23 17:17:49 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2954013002/80001
3 years, 6 months ago (2017-06-23 18:01:22 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/472477)
3 years, 6 months ago (2017-06-23 18:04:22 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2954013002/100001
3 years, 6 months ago (2017-06-23 18:13:52 UTC) #26
commit-bot: I haz the power
3 years, 6 months ago (2017-06-23 20:41:30 UTC) #31
Message was sent while issue was closed.
Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/07a754c70339bd975c433dfe344f...

Powered by Google App Engine
This is Rietveld 408576698