Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4418)

Unified Diff: base/strings/utf_offset_string_conversions_unittest.cc

Issue 2953943003: base::OffsetAdjuster: Refactor offset limiting logic into the base::OffsetAdjuster (Closed)
Patch Set: fix test Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/strings/utf_offset_string_conversions.cc ('k') | components/url_formatter/url_formatter.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/strings/utf_offset_string_conversions_unittest.cc
diff --git a/base/strings/utf_offset_string_conversions_unittest.cc b/base/strings/utf_offset_string_conversions_unittest.cc
index fe0e4da81af26b80cd8c68a17904ccbd8ff19fa0..c365d9e57ff1cf0775693d4640c3de90d0241d76 100644
--- a/base/strings/utf_offset_string_conversions_unittest.cc
+++ b/base/strings/utf_offset_string_conversions_unittest.cc
@@ -77,13 +77,14 @@ TEST(UTFOffsetStringConversionsTest, AdjustOffset) {
}
TEST(UTFOffsetStringConversionsTest, LimitOffsets) {
+ const OffsetAdjuster::Adjustments kNoAdjustments;
const size_t kLimit = 10;
const size_t kItems = 20;
std::vector<size_t> size_ts;
- for (size_t t = 0; t < kItems; ++t)
+ for (size_t t = 0; t < kItems; ++t) {
size_ts.push_back(t);
- std::for_each(size_ts.begin(), size_ts.end(),
- LimitOffset<string16>(kLimit));
+ OffsetAdjuster::AdjustOffset(kNoAdjustments, &size_ts.back(), kLimit);
+ }
size_t unlimited_count = 0;
for (std::vector<size_t>::iterator ti = size_ts.begin(); ti != size_ts.end();
++ti) {
@@ -94,10 +95,10 @@ TEST(UTFOffsetStringConversionsTest, LimitOffsets) {
// Reverse the values in the vector and try again.
size_ts.clear();
- for (size_t t = kItems; t > 0; --t)
+ for (size_t t = kItems; t > 0; --t) {
size_ts.push_back(t - 1);
- std::for_each(size_ts.begin(), size_ts.end(),
- LimitOffset<string16>(kLimit));
+ OffsetAdjuster::AdjustOffset(kNoAdjustments, &size_ts.back(), kLimit);
+ }
unlimited_count = 0;
for (std::vector<size_t>::iterator ti = size_ts.begin(); ti != size_ts.end();
++ti) {
« no previous file with comments | « base/strings/utf_offset_string_conversions.cc ('k') | components/url_formatter/url_formatter.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698