Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 2953903002: Move test infer_use_of_void to inference_new (Closed)

Created:
3 years, 6 months ago by Paul Berry
Modified:
3 years, 6 months ago
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Move test infer_use_of_void to inference_new This test's expectations reflect a drawback in analyzer's type inference--it doesn't infer the correct types for calls to methods returning `void` when those calls occur outside of a method body. The new front_end type inference engine does the right thing. Accordingly, we have to move the test to inference_new, so that we can update its expectations without breaking analyzer's test code. R=ahe@google.com Committed: https://github.com/dart-lang/sdk/commit/c4ecf098aadf92155a2654a01ffe0b82628ce7f4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -37 lines) Patch
M pkg/front_end/test/fasta/compile.status View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/front_end/test/fasta/kompile.status View 2 chunks +1 line, -1 line 0 comments Download
M pkg/front_end/test/fasta/outline.status View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/front_end/test/fasta/strong.status View 1 chunk +0 lines, -1 line 0 comments Download
D pkg/front_end/testcases/inference/infer_use_of_void.dart View 1 chunk +0 lines, -21 lines 0 comments Download
A + pkg/front_end/testcases/inference/infer_use_of_void_local.dart View 1 chunk +4 lines, -11 lines 0 comments Download
A pkg/front_end/testcases/inference/infer_use_of_void_local.dart.dartk.expect View 1 chunk +8 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/infer_use_of_void_local.dart.direct.expect View 1 chunk +8 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/infer_use_of_void_local.dart.outline.expect View 1 chunk +9 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/infer_use_of_void_local.dart.strong.expect View 1 chunk +8 lines, -0 lines 0 comments Download
A + pkg/front_end/testcases/inference_new/infer_use_of_void.dart View 1 chunk +1 line, -1 line 0 comments Download
A pkg/front_end/testcases/inference_new/infer_use_of_void.dart.direct.expect View 1 chunk +20 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference_new/infer_use_of_void.dart.outline.expect View 1 chunk +19 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference_new/infer_use_of_void.dart.strong.expect View 1 chunk +20 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Paul Berry
3 years, 6 months ago (2017-06-22 20:58:22 UTC) #2
ahe
lgtm
3 years, 6 months ago (2017-06-23 12:33:54 UTC) #4
Paul Berry
3 years, 6 months ago (2017-06-23 14:33:58 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c4ecf098aadf92155a2654a01ffe0b82628ce7f4 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698