Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(545)

Issue 2953873002: Fix previous CL where dart_bootstrap was accidently changed to dart_bootstrap_host_arch (Closed)

Created:
3 years, 6 months ago by aam
Modified:
3 years, 6 months ago
Reviewers:
zra, rmacnak
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix previous CL where dart_bootstrap was accidently changed to dart_bootstrap_host_arch. Also fix two missed places where host_toolchain should be replaced with dart_host_toolchain. R=rmacnak@google.com BUG:flutter/flutter#10841 Committed: https://github.com/dart-lang/sdk/commit/4f9b25e410ed63028945e47386b434ed8cd8c313

Patch Set 1 #

Patch Set 2 : And two more places where host_toolchain should be replaced with dart_host_toolchain #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M BUILD.gn View 1 3 chunks +4 lines, -2 lines 0 comments Download
M utils/generate_patch_sdk.gni View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
aam
PTAL, thanks!
3 years, 6 months ago (2017-06-22 20:06:20 UTC) #2
rmacnak
lgtm
3 years, 6 months ago (2017-06-22 20:16:44 UTC) #5
aam
3 years, 6 months ago (2017-06-22 20:17:58 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
4f9b25e410ed63028945e47386b434ed8cd8c313 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698