[Android Site Settings] Disable fetching important sites when not needed

chrome/android/java/src/org/chromium/chrome/browser/preferences/website/WebsitePermissionsFetcher.java

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chrome.browser.preferences.website;
 
 import android.util.Pair;
 
 import org.chromium.base.Callback;
 import org.chromium.chrome.browser.ContentSettingsType;
@@ skipping 16 matching lines @@
     public interface WebsitePermissionsCallback {
         void onWebsitePermissionsAvailable(Collection<Website> sites);
     }
 
     // This map looks up Websites by their origin and embedder.
     private final Map<Pair<WebsiteAddress, WebsiteAddress>, Website> mSites = new HashMap<>();
 
     // The callback to run when the permissions have been fetched.
     private final WebsitePermissionsCallback mCallback;
 
+    private final boolean mFetchSiteImportantInfo;
+
     /**
      * @param callback The callback to run when the fetch is complete.
      */
     public WebsitePermissionsFetcher(WebsitePermissionsCallback callback) {

[Ted C, 2017/06/22 20:06:49]

replace the two lines with:

this(callback, false);

[dmurph, 2017/06/23 00:22:48]

Done.

         mCallback = callback;
+        mFetchSiteImportantInfo = false;
     }
 
     /**
+     * @param callback The callback to run when the fetch is complete.

[Ted C, 2017/06/22 20:06:49]

add a @param for fetchSiteImportantInfo

[dmurph, 2017/06/23 00:22:48]

Done.

+     */
+    public WebsitePermissionsFetcher(
+            WebsitePermissionsCallback callback, boolean fetchSiteImportantInfo) {
+        mCallback = callback;
+        mFetchSiteImportantInfo = fetchSiteImportantInfo;
+    }
+
+    /**
      * Fetches preferences for all sites that have them.
      * TODO(mvanouwerkerk): Add an argument |url| to only fetch permissions for
      * sites from the same origin as that of |url| - https://crbug.com/459222.
      */
     public void fetchAllPreferences() {
         TaskQueue queue = new TaskQueue();
         // Populate features from more specific to less specific.
         // Geolocation lookup permission is per-origin and per-embedder.
         queue.add(new GeolocationInfoFetcher());
         // Midi sysex access permission is per-origin and per-embedder.
@@ skipping 236 matching lines @@
                     for (Object o : result.entrySet()) {
                         @SuppressWarnings("unchecked")
                         Map.Entry<String, LocalStorageInfo> entry =
                                 (Map.Entry<String, LocalStorageInfo>) o;
                         WebsiteAddress address = WebsiteAddress.create(entry.getKey());
                         if (address == null) continue;
                         findOrCreateSite(address, null).setLocalStorageInfo(entry.getValue());
                     }
                     queue.next();
                 }
-            });
+            }, mFetchSiteImportantInfo);
         }
     }
 
     private class WebStorageInfoFetcher extends Task {
         @Override
         public void runAsync(final TaskQueue queue) {
             WebsitePreferenceBridge.fetchStorageInfo(new Callback<ArrayList>() {
                 @Override
                 public void onResult(ArrayList result) {
                     @SuppressWarnings("unchecked")
@@ skipping 78 matching lines @@
         }
     }
 
     private class PermissionsAvailableCallbackRunner extends Task {
         @Override
         public void run() {
             mCallback.onWebsitePermissionsAvailable(mSites.values());
         }
     }
 }