Issue 2953843003: Reintroducing parser changes to cause compile-time errors when trying to reinitialize a final field…

Issue 2953843003: Reintroducing parser changes to cause compile-time errors when trying to reinitialize a final field… (Closed)

Created:
3 years, 6 months ago by bkonyi

Modified:
3 years, 6 months ago

Reviewers:
zra

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Reintroducing parser changes to cause compile-time errors when trying to reinitialize a final field. Updated status files to hopefully address the test failures. Issue 29658. This reverts commit 12e93cc41eed955245cae7bf8a8e931f23cc6fb6. BUG= R=zra@google.com Committed: https://github.com/dart-lang/sdk/commit/143baba8fc54025ee0185a9d4602f79f2bf8887f

Created: 3 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+90 lines, -6 lines)			Patch
M	runtime/vm/parser.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	runtime/vm/parser.cc	View	3 chunks	+49 lines, -0 lines	0 comments	Download
M	tests/co19/co19-dartium.status	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	tests/co19/co19-runtime.status	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	tests/language/const_error_multiply_initialized_test.dart	View	2 chunks	+3 lines, -3 lines	0 comments	Download
A	tests/language/final_attempt_reinitialization_test.dart	View	1 chunk	+20 lines, -0 lines	0 comments	Download
M	tests/language/language_analyzer2.status	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	tests/language/language_dart2js.status	View	2 chunks	+2 lines, -3 lines	0 comments	Download
M	tests/language/language_kernel.status	View	1 chunk	+2 lines, -0 lines	0 comments	Download

Total messages: 5 (2 generated)

bkonyi

3 years, 6 months ago (2017-06-22 20:49:04 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
143baba8fc54025ee0185a9d4602f79f2bf8887f (presubmit successful).