Mojo: Require our public options structs to be aligned like int64_t's.

Mojo: Require our public options structs to be aligned like int64_t's.

The structs are meant to be extensible and part of the ABI, and not
requiring such alignment of them would mean that it'd be difficult to
add (u)int64_t's (or anything aligned like them) to them in the future.

R=darin@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273508

[darin (slow to review), 2014-05-28 21:35:14]

https://codereview.chromium.org/295383012/diff/1/mojo/public/c/system/macros.h
File mojo/public/c/system/macros.h (right):

https://codereview.chromium.org/295383012/diff/1/mojo/public/c/system/macros....
mojo/public/c/system/macros.h:45: #define MOJO_ALIGNOF(type) alignof(type)
I wonder if these shouldn't be MOJO_ALIGN_OF and MOJO_ALIGN_AS to help
readability. I realize the natives don't have the underscores, but ALIGNAS in
particular took be a moment to parse.

[darin (slow to review), 2014-05-28 21:35:19]

LGTM

[viettrungluu, 2014-05-28 23:24:26]

On 2014/05/28 21:35:14, darin wrote:
> https://codereview.chromium.org/295383012/diff/1/mojo/public/c/system/macros.h
> File mojo/public/c/system/macros.h (right):
> 
>
https://codereview.chromium.org/295383012/diff/1/mojo/public/c/system/macros....
> mojo/public/c/system/macros.h:45: #define MOJO_ALIGNOF(type) alignof(type)
> I wonder if these shouldn't be MOJO_ALIGN_OF and MOJO_ALIGN_AS to help
> readability. I realize the natives don't have the underscores, but ALIGNAS in
> particular took be a moment to parse.

I thought about this, but I'm following the precedent of
base/compiler_specific.h (and V8 also has V8_ALIGNOF and V8_ALIGNAS).

[viettrungluu, 2014-05-28 23:24:44]

The CQ bit was checked by viettrungluu@chromium.org

[commit-bot: I haz the power, 2014-05-28 23:26:43]

CQ is trying da patch. Follow status at

https://chromium-status.appspot.com/cq/viettrungluu@chromium.org/295383012/20001

[commit-bot: I haz the power, 2014-05-29 03:27:44]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_compile_...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)

[commit-bot: I haz the power, 2014-05-29 04:44:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-29 04:44:06]

Try jobs failed on following builders:
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)

[viettrungluu, 2014-05-29 17:22:15]

Committed patchset #3 manually as r273508 (presubmit successful).