Remove the forceCompositingMode setting.

Remove the forceCompositingMode setting.

Nothing sets it to false anymore. This also means we can
remove all the machinery around setting this via
enterForceCompositingMode. Unfortunately, WebPopupMenuImpl
still needs enterForceCompositingMode. That's crbug.com/378029.

BUG=363772, 378029
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175027

[ojan, 2014-05-27 23:08:53]

Enne, mind doing an initial review and, Pavel, I'll need your final LGTM for the
Source/web and public/web bits.

[enne (OOO), 2014-05-27 23:44:12]

lgtm

https://codereview.chromium.org/295383008/diff/1/Source/web/WebPopupMenuImpl.cpp
File Source/web/WebPopupMenuImpl.cpp (right):

https://codereview.chromium.org/295383008/diff/1/Source/web/WebPopupMenuImpl....
Source/web/WebPopupMenuImpl.cpp:209: // FIXME: Is this function really correct?
The other overrides of this function
This is the equivalent of WebViewImpl::setRootGraphicsLayer.  Maybe this could
all just get moved to WebPopupMenuImpl::initialize?

Also, there are no callers of enterForceCompositingMode(false) anymore, so the
only branch that's needed here is the one that creates the layer tree view and
root layer.

[ojan, 2014-05-27 23:54:34]

https://codereview.chromium.org/295383008/diff/1/Source/web/WebPopupMenuImpl.cpp
File Source/web/WebPopupMenuImpl.cpp (right):

https://codereview.chromium.org/295383008/diff/1/Source/web/WebPopupMenuImpl....
Source/web/WebPopupMenuImpl.cpp:209: // FIXME: Is this function really correct?
The other overrides of this function
On 2014/05/27 23:44:13, enne wrote:
> This is the equivalent of WebViewImpl::setRootGraphicsLayer.  Maybe this could
> all just get moved to WebPopupMenuImpl::initialize?
> 
> Also, there are no callers of enterForceCompositingMode(false) anymore, so the
> only branch that's needed here is the one that creates the layer tree view and
> root layer.

This is called with false in this file unfortunately in
WebPopupMenuImpl::willCloseLayerTreeView. willCloseLayerTreeView in
WebPagePopupImpl and WebViewImpl call setIsAcceleratedCompositingActive instead,
which I think this was this function should be called to match those. But, I
didn't want to risk changing any behavior with this patch.

[ojan, 2014-05-28 18:06:59]

pfeldman, mind taking a quick look? This is a pretty mechanical change.

[pfeldman, 2014-05-28 19:20:51]

lgtm w/ a nit

https://codereview.chromium.org/295383008/diff/1/Source/devtools/Inspector-1....
File Source/devtools/Inspector-1.1.json (left):

https://codereview.chromium.org/295383008/diff/1/Source/devtools/Inspector-1....
Source/devtools/Inspector-1.1.json:499: "name": "setForceCompositingMode",
No need to remove this. It captures the 1.1 version of the protocol to test
backwards compatibility. Since the method was hidden, it was fine to remove it
from protocol.json and leave it here.

[ojan, 2014-05-29 01:51:53]

The CQ bit was checked by ojan@chromium.org

[commit-bot: I haz the power, 2014-05-29 01:52:25]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/ojan@chromium.org/295383008/20001

[commit-bot: I haz the power, 2014-05-29 03:14:00]

Change committed as 175027