Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4324)

Unified Diff: chrome/browser/io_thread.cc

Issue 295383007: Get rid of websocket_over_spdy_enabled global. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix tests Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/io_thread.cc
diff --git a/chrome/browser/io_thread.cc b/chrome/browser/io_thread.cc
index 540a26f61d1932676db6678e1d9d51d31aea4ffd..63fb74a86eefeda4adcdd023ce331bdc5f57dd84 100644
--- a/chrome/browser/io_thread.cc
+++ b/chrome/browser/io_thread.cc
@@ -79,7 +79,6 @@
#include "net/url_request/url_fetcher.h"
#include "net/url_request/url_request_job_factory_impl.h"
#include "net/url_request/url_request_throttler_manager.h"
-#include "net/websockets/websocket_job.h"
#if defined(ENABLE_CONFIGURATION_POLICY)
#include "policy/policy_constants.h"
@@ -748,11 +747,6 @@ void IOThread::InitializeNetworkOptions(const CommandLine& command_line) {
std::string spdy_trial_group =
base::FieldTrialList::FindFullName(kSpdyFieldTrialName);
- if (command_line.HasSwitch(switches::kEnableWebSocketOverSpdy)) {
- // Enable WebSocket over SPDY.
- net::WebSocketJob::set_websocket_over_spdy_enabled(true);
- }
-
if (command_line.HasSwitch(switches::kTrustedSpdyProxy)) {
globals_->trusted_spdy_proxy.set(
command_line.GetSwitchValueASCII(switches::kTrustedSpdyProxy));
@@ -783,6 +777,9 @@ void IOThread::InitializeNetworkOptions(const CommandLine& command_line) {
globals_->use_alternate_protocols.set(true);
}
}
+
+ if (command_line.HasSwitch(switches::kEnableWebSocketOverSpdy))
+ globals_->enable_websocket_over_spdy.set(true);
}
// TODO(rch): Make the client socket factory a per-network session
@@ -971,6 +968,9 @@ void IOThread::InitializeNetworkSessionParams(
&params->origin_to_force_quic_on);
params->enable_user_alternate_protocol_ports =
globals_->enable_user_alternate_protocol_ports;
+
+ globals_->enable_websocket_over_spdy.CopyToIfSet(
+ &params->enable_websocket_over_spdy);
}
base::TimeTicks IOThread::creation_time() const {

Powered by Google App Engine
This is Rietveld 408576698