Issue 295383004: Refactor CallICStub to use a different stub for each customization.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 295383004: Refactor CallICStub to use a different stub for each customization. (Closed)

Created:
6 years, 6 months ago by mvstanton

Modified:
6 years, 6 months ago

Reviewers:
Toon Verwaest

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Refactor CallICStub to use a different stub for each customization. This gives us much more room to customize on different functions, by using MajorKey to differentiate them. R=verwaest@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21564

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+121 lines, -211 lines)			Patch
M	src/arm/code-stubs-arm.cc	View	1 2	6 chunks	+12 lines, -27 lines	0 comments	Download
M	src/arm64/code-stubs-arm64.cc	View	1 2	6 chunks	+9 lines, -27 lines	0 comments	Download
M	src/code-stubs.h	View	1	2 chunks	+17 lines, -5 lines	0 comments	Download
M	src/code-stubs.cc	View	1	1 chunk	+6 lines, -0 lines	0 comments	Download
M	src/ia32/code-stubs-ia32.cc	View	1	6 chunks	+12 lines, -27 lines	0 comments	Download
M	src/ic.h	View	1	4 chunks	+7 lines, -42 lines	0 comments	Download
M	src/ic.cc	View	1	7 chunks	+35 lines, -27 lines	0 comments	Download
M	src/mips/code-stubs-mips.cc	View	1 2	6 chunks	+10 lines, -27 lines	0 comments	Download
M	src/x64/code-stubs-x64.cc	View	1 2	6 chunks	+13 lines, -29 lines	0 comments	Download

Total messages: 3 (0 generated)

mvstanton

Refactoring that defines customization of a callic as installing an inherited stub. Thanks for the ...

6 years, 6 months ago (2014-05-27 12:14:26 UTC) #1

mvstanton

6 years, 6 months ago (2014-05-28 11:30:10 UTC) #3

Message was sent while issue was closed.

Committed patchset #3 manually as r21564 (presubmit successful).